[PATCH] Remove unused #include's in src/backend/utils/adt/*

Started by Aleksander Alekseev10 months ago4 messageshackers
Jump to latest
#1Aleksander Alekseev
aleksander@timescale.com

Hi,

clangd indicates that certain #include's are redundant. Removing them
will speed up the build process a bit.

--
Best regards,
Aleksander Alekseev

Attachments:

v1-0001-Remove-unused-include-s-in-src-backend-utils-adt.patchapplication/octet-stream; name=v1-0001-Remove-unused-include-s-in-src-backend-utils-adt.patchDownload+0-11
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Aleksander Alekseev (#1)
Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

Aleksander Alekseev <aleksander@timescale.com> writes:

clangd indicates that certain #include's are redundant. Removing them
will speed up the build process a bit.

The removals of <math.h> bother me a bit; I believe those used
to be necessary on some platforms. Maybe nowadays everybody is
close enough to POSIX that you can safely extrapolate from what
clangd says on your own machine, but it's not zero-risk.

regards, tom lane

#3Aleksander Alekseev
aleksander@timescale.com
In reply to: Tom Lane (#2)
Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

Hi Tom,

The removals of <math.h> bother me a bit; I believe those used
to be necessary on some platforms. Maybe nowadays everybody is
close enough to POSIX that you can safely extrapolate from what
clangd says on your own machine, but it's not zero-risk.

Sounds good to me, let's keep <math.h>.

--
Best regards,
Aleksander Alekseev

Attachments:

v2-0001-Remove-unused-include-s-in-src-backend-utils-adt.patchapplication/octet-stream; name=v2-0001-Remove-unused-include-s-in-src-backend-utils-adt.patchDownload+0-9
#4Peter Eisentraut
peter_e@gmx.net
In reply to: Aleksander Alekseev (#3)
Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

On 16.06.25 16:20, Aleksander Alekseev wrote:

The removals of <math.h> bother me a bit; I believe those used
to be necessary on some platforms. Maybe nowadays everybody is
close enough to POSIX that you can safely extrapolate from what
clangd says on your own machine, but it's not zero-risk.

Sounds good to me, let's keep <math.h>.

committed