model-writtenrun 6932 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Aleksander Alekseev opened the thread with a C implementation that moved opening text in column-one multiline comments onto a separate starred line, crediting Michael Paquier for identifying the formatting issue #1.
- Arseniy Mukhin's whole-tree testing exposed comments without interior stars and closing delimiters sharing a text line #2, prompting Aleksander to replace the C implementation with Perl postprocessing in pgindent #3; Bruce Momjian supported using the wrapper because BSD indent was difficult to maintain #4.
- Aleksander corrected the closing-delimiter substitution #5, and Arseniy's further tests exposed decorative borders and mixed-format comments #7; the next revision tightened eligibility checks and supplied missing interior stars while initially leaving border exceptions out #8.
- After a four-month gap, Nathan Bossart tested the patch and argued that rewriting dashed borders caused unnecessary churn #9, leading Aleksander to preserve dashed and equals-sign borders #10.
- Nathan's next test found that formatting required two passes and exposed malformed comments, embedded debugging directives, and remaining decorative-border problems #11; he separately corrected the two malformed comments in nodeWindowAgg.c and waiteventset.c through 123661427b, without an attached patch.
- Michael Paquier recommended moving the debugging directive outside the explanatory comment to follow pg_config_manual.h #12, and Chao Li endorsed that approach #13.
- Chao also reported a typo and possible formatting regressions #14; Aleksander corrected the typo #15, and Chao subsequently confirmed that tests on already-formatted files produced no changes, resolving his concern #16.
- Nathan supplied a separate cleanup moving debugging directives into standalone commented defines in three files #17, while continuing to question decorative and mixed-format comment handling in the formatter #18; Aleksander explained that protected comments could use an extra opening star, while mixed-format comments would otherwise be normalized #19.
- The discussion broadened to maintaining or replacing BSD indent: Alvaro Herrera advocated taking ownership of its C implementation #20, Nathan considered a rewrite #22, and Tom Lane noted both its potential simplifications and substantial cost #23; Aleksander suggested a possible future Python wrapper #24, while Michael favored simplifying and consolidating the existing layers #26, with no replacement implementation submitted.
- Nathan committed the debugging-macro patch from #17 unchanged as ba1e14134a and announced it in #27; Aleksander then resent the unchanged formatter patch to restore cfbot visibility #28.
- Tom's May testing found trailing whitespace left by delimiter splitting, patterns that assumed single spaces, and a need for pgperltidy #29; he also identified a source-comment typo that Nathan agreed should be fixed manually #30.
- Aleksander's final submission in this thread broadened whitespace matching, removed trailing whitespace during delimiter splitting, and applied pgperltidy #31, leaving the formatter awaiting commitment at the end of the supplied messages.
- Further revisions in thread #139153 superseded this thread's final submission: that thread identifies Tom's #1003620 as the exact source of 60f9467c38, retaining Aleksander's authorship while broadening multiline-comment eligibility and normalizing leading stars and whitespace.
- The formatter and the earlier source cleanups ultimately landed, with the formatter's final patchset attributed to thread #139153; the broader formatter-rewrite ideas remained unimplemented in this thread.