Removing rm regress.def

Started by Christoph Berg10 months ago4 messageshackers
Jump to latest
#1Christoph Berg
myon@debian.org

pgxs.mk is cleaning up a file "regress.def" if PORTNAME=win, but the
only reference to that file I could find is in the original commit
from 1999 adding that "rm" rule (and several commits moving the rule
around later).

Given that the PORTNAME is wrong (should be win32), it's probably safe
to just delete the rule.

Christoph

Attachments:

0001-pgxs.mk-Remove-bogus-PORTNAME-win-rule.patchtext/x-diff; charset=us-asciiDownload+0-4
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Christoph Berg (#1)
Re: Removing rm regress.def

Christoph Berg <myon@debian.org> writes:

pgxs.mk is cleaning up a file "regress.def" if PORTNAME=win, but the
only reference to that file I could find is in the original commit
from 1999 adding that "rm" rule (and several commits moving the rule
around later).

Given that the PORTNAME is wrong (should be win32), it's probably safe
to just delete the rule.

Yeah, seems quite bogus. It's harmless though, so I don't
see a need to back-patch, do you?

regards, tom lane

#3Christoph Berg
myon@debian.org
In reply to: Tom Lane (#2)
Re: Removing rm regress.def

Re: Tom Lane

Yeah, seems quite bogus. It's harmless though, so I don't
see a need to back-patch, do you?

Other than it being confusing, it doesn't hurt.

Christoph

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Christoph Berg (#3)
Re: Removing rm regress.def

Christoph Berg <myon@debian.org> writes:

Re: Tom Lane

Yeah, seems quite bogus. It's harmless though, so I don't
see a need to back-patch, do you?

Other than it being confusing, it doesn't hurt.

OK, applied to master only.

regards, tom lane