Fix typo in commens on ExecInsertIndexTuples
Hi,
I found typos in the comments of ExecInsertIndexTuples
that mention TUUI_{All, Summarizing} but they should be
TU_*.
I've attached a patch to fix it.
Regards,
Yugo Nagata
--
Yugo Nagata <nagata@sraoss.co.jp>
Attachments:
fix_commens_on_ExecInsertIndexTuples.patchtext/x-diff; name=fix_commens_on_ExecInsertIndexTuples.patchDownload
diff --git a/src/backend/executor/execIndexing.c b/src/backend/executor/execIndexing.c
index bdf862b2406..ca33a854278 100644
--- a/src/backend/executor/execIndexing.c
+++ b/src/backend/executor/execIndexing.c
@@ -279,7 +279,7 @@ ExecCloseIndices(ResultRelInfo *resultRelInfo)
* executor is performing an UPDATE that could not use an
* optimization like heapam's HOT (in more general terms a
* call to table_tuple_update() took place and set
- * 'update_indexes' to TUUI_All). Receiving this hint makes
+ * 'update_indexes' to TU_All). Receiving this hint makes
* us consider if we should pass down the 'indexUnchanged'
* hint in turn. That's something that we figure out for
* each index_insert() call iff 'update' is true.
@@ -290,7 +290,7 @@ ExecCloseIndices(ResultRelInfo *resultRelInfo)
* HOT has been applied and any updated columns are indexed
* only by summarizing indexes (or in more general terms a
* call to table_tuple_update() took place and set
- * 'update_indexes' to TUUI_Summarizing). We can (and must)
+ * 'update_indexes' to TU_Summarizing). We can (and must)
* therefore only update the indexes that have
* 'amsummarizing' = true.
*
Hi Nagata-san,
On Tue, Jul 1, 2025 at 11:02 AM Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found typos in the comments of ExecInsertIndexTuples
that mention TUUI_{All, Summarizing} but they should be
TU_*.I've attached a patch to fix it.
Good catch and thanks for the patch. Will push shortly.
--
Thanks, Amit Langote
On Tue, Jul 1, 2025 at 11:42 AM Amit Langote <amitlangote09@gmail.com> wrote:
Hi Nagata-san,
On Tue, Jul 1, 2025 at 11:02 AM Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found typos in the comments of ExecInsertIndexTuples
that mention TUUI_{All, Summarizing} but they should be
TU_*.I've attached a patch to fix it.
Good catch and thanks for the patch. Will push shortly.
Done and backpatched to v16, where the faulty comments were introduced.
--
Thanks, Amit Langote
On Tue, 1 Jul 2025 13:29:44 +0900
Amit Langote <amitlangote09@gmail.com> wrote:
On Tue, Jul 1, 2025 at 11:42 AM Amit Langote <amitlangote09@gmail.com> wrote:
Hi Nagata-san,
On Tue, Jul 1, 2025 at 11:02 AM Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found typos in the comments of ExecInsertIndexTuples
that mention TUUI_{All, Summarizing} but they should be
TU_*.I've attached a patch to fix it.
Good catch and thanks for the patch. Will push shortly.
Done and backpatched to v16, where the faulty comments were introduced.
Thanks!
Regards,
Yugo Nagata
--
Yugo Nagata <nagata@sraoss.co.jp>