Correct comment atop PublicationPartOpt
Started by shveta malik7 months ago2 messages
Hi,
I found the wrong function name mentioned in the comment atop
PublicationPartOpt.
Comment wrongly mentioned the function name GetRelationPublications()
for PublicationPartOpt usage instead of GetPublicationRelations().
Corrected the comment.
thanks
Shveta
Attachments:
v1-0001-Comment-correction-atop-PublicationPartOpt.patchapplication/octet-stream; name=v1-0001-Comment-correction-atop-PublicationPartOpt.patchDownload
From b467fe51543b5cf0fef248b76f6d0bd0f5a0e489 Mon Sep 17 00:00:00 2001
From: Shveta Malik <shveta.malik@gmail.com>
Date: Tue, 1 Jul 2025 09:13:38 +0530
Subject: [PATCH v1] Comment correction atop PublicationPartOpt.
Comment wrongly mentions function name GetRelationPublications()
for PublicationPartOpt usage instead of GetPublicationRelations().
Corrected the comment.
---
src/include/catalog/pg_publication.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/include/catalog/pg_publication.h b/src/include/catalog/pg_publication.h
index 48c7d1a8615..6e074190fd2 100644
--- a/src/include/catalog/pg_publication.h
+++ b/src/include/catalog/pg_publication.h
@@ -146,7 +146,7 @@ extern Publication *GetPublicationByName(const char *pubname, bool missing_ok);
extern List *GetRelationPublications(Oid relid);
/*---------
- * Expected values for pub_partopt parameter of GetRelationPublications(),
+ * Expected values for pub_partopt parameter of GetPublicationRelations(),
* which allows callers to specify which partitions of partitioned tables
* mentioned in the publication they expect to see.
*
--
2.34.1
Re: Correct comment atop PublicationPartOpt
On Tue, Jul 1, 2025 at 9:20 AM shveta malik <shveta.malik@gmail.com> wrote:
I found the wrong function name mentioned in the comment atop
PublicationPartOpt.Comment wrongly mentioned the function name GetRelationPublications()
for PublicationPartOpt usage instead of GetPublicationRelations().
Corrected the comment.
LGTM.
--
With Regards,
Amit Kapila.