Fix inconsistency in the pg_buffercache documentation

Started by Bertrand Drouvot10 months ago4 messageshackers
Jump to latest
#1Bertrand Drouvot
bertranddrouvot.pg@gmail.com

Hi hackers,

While working on [1]/messages/by-id/Z/fFA2heH6lpSLlt@ip-10-97-1-34.eu-west-3.compute.internal, I noticed an inconsistency in the pg_buffercache
documentation: ba2a3c2302f1 missed to add "the" before the pg_buffercache_numa()
function introduction.

PFA a tiny patch to add it for consistency purpose. Should be back-patched to
18 where pg_buffercache_numa() has been introduced.

[1]: /messages/by-id/Z/fFA2heH6lpSLlt@ip-10-97-1-34.eu-west-3.compute.internal

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachments:

v1-0001-Fix-inconsistency-in-the-pg_buffercache-documenta.patchtext/x-diff; charset=us-asciiDownload+1-2
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Bertrand Drouvot (#1)
Re: Fix inconsistency in the pg_buffercache documentation

On 2 Jul 2025, at 08:23, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:

Hi hackers,

While working on [1], I noticed an inconsistency in the pg_buffercache
documentation: ba2a3c2302f1 missed to add "the" before the pg_buffercache_numa()
function introduction.

Thanks, that does indeed look like an omission. There seems to be a few more
on the same page however, how about the attached?

--
Daniel Gustafsson

Attachments:

pg_buffercache.diffapplication/octet-stream; name=pg_buffercache.diff; x-unix-mode=0644Download+3-3
#3Bertrand Drouvot
bertranddrouvot.pg@gmail.com
In reply to: Daniel Gustafsson (#2)
Re: Fix inconsistency in the pg_buffercache documentation

Hi,

On Wed, Jul 02, 2025 at 09:55:52AM +0200, Daniel Gustafsson wrote:

On 2 Jul 2025, at 08:23, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:

Hi hackers,

While working on [1], I noticed an inconsistency in the pg_buffercache
documentation: ba2a3c2302f1 missed to add "the" before the pg_buffercache_numa()
function introduction.

Thanks, that does indeed look like an omission.

Thanks for looking at it!

There seems to be a few more
on the same page however,

Indeed, there is multiple kind of inconsistency that are worth to fix.

how about the attached?

LGTM.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

#4Daniel Gustafsson
daniel@yesql.se
In reply to: Bertrand Drouvot (#3)
Re: Fix inconsistency in the pg_buffercache documentation

On 2 Jul 2025, at 10:06, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:
On Wed, Jul 02, 2025 at 09:55:52AM +0200, Daniel Gustafsson wrote:

how about the attached?

LGTM.

Thanks, committed.

--
Daniel Gustafsson