Jul - Aug 2025

5 commits
Rewrite previous commit's test for TestUpgradeXversion compatibility.
23 Aug 2025Noah Mischmaster19beta1REL_19_STABLE19beta1REL_18_STABLE18rc1REL_17_STABLE17.7REL_16_STABLE16.11REL_15_STABLE15.15REL_14_STABLE14.20REL_13_STABLE13.23
LLM analysis, 100% surewritten from the discussion, no matching patch

The commit changes REVOKE INSERT ON TABLES to REVOKE USAGE ON TYPES in privileges.sql and privileges.out, addressing the cross-version failure reported in #18. Noah explains the committed fix in #19; no attachment contains this change.

Sort DO_DEFAULT_ACL dump objects independent of OIDs.
23 Aug 2025Noah Mischmaster19beta1REL_19_STABLE19beta1REL_18_STABLE18rc1REL_17_STABLE17.7REL_16_STABLE16.11REL_15_STABLE15.15REL_14_STABLE14.20REL_13_STABLE13.23
LLM analysis, 100% suremodified before commitlight changesfrom patchset #141 of 2 reviewers saw the final version

The commit retains the role-name comparator and both default-ACL test statements from #14, moving the comparator branch and test placement and expanding the comment. Noah confirms cosmetic changes in #17.

  • Alexander Lakhinsaw an earlier versionLLM analysis, 95% sureAlexander reproduced the missed default-ACL case on master and v13 in #9, prompting the new comparator logic subsequently supplied in #10.
  • Noah Mischsaw the final versioncommittercommitted the patch
Remove, from stable branches, the new assertion of no pg_dump OID sort.
10 Aug 2025Noah MischREL_18_STABLE18beta3REL_17_STABLE17.6REL_16_STABLE16.10REL_15_STABLE15.14REL_14_STABLE14.19REL_13_STABLE13.22
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

The sole code change removes Assert(false) before the OID fallback in DOTypeNameCompare, implementing Noah's stable-branch mitigation proposed in #11 and endorsed in #12 and #13. No attached patch proposes that removal.

  • Robert Haassaw the final versiontrailerRobert endorsed removing the stable-branch assertion in #12 during consideration of #10, whose later attached revision added only tests.
  • Tom Lanesaw the final versiontrailerTom supported assertion removal and postponing the default-ACL fix in #13, with only test additions following in #14.
pg_dump: provide a stable sort order for rules.
31 Jul 2025Noah MischREL_17_STABLE17.6REL_16_STABLE16.10REL_15_STABLE15.14REL_14_STABLE14.19REL_13_STABLE13.22Also in: Always have pg_dump write rules in a consistent order (modified before commit)
LLM analysis, 99% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

The commit adds the existing DO_RULE table-name tiebreaker, credited to Andreas Karlsson, as a prerequisite for the new assertion. This unattached backport was proposed in #5 and accepted in #6.

  • Robert Haassaw the final versionLLM analysis, 94% sureRobert explicitly accepted backporting the existing rule-sorting fix in #6, while noting that he had not separately read the branch adaptations.
  • Noah Mischsaw the final versioncommittercommitted the patch
Sort dump objects independent of OIDs, for the 7 holdout object types.
31 Jul 2025Noah Mischmaster19beta1REL_19_STABLE19beta1REL_18_STABLE18beta3REL_17_STABLE17.6REL_16_STABLE16.10REL_15_STABLE15.14REL_14_STABLE14.19REL_13_STABLE13.22
LLM analysis, 100% surelanded as postedfrom patchset #51 of 1 reviewer saw the final version

Applying the development-branch patch from #5 to the commit's parent reproduces all six committed files byte-for-byte. The extra compatibility changes described in #8 concern older-branch backports.

  • Robert Haassaw the final versiontrailerRobert reviewed the initial patch in #2, refined its comments in #4, and explicitly reported reading the final development-branch patch without further comments in #6.

Credits across 5 commits

Author
Andreas KarlssonLLM1
Kirill Reshke1
Noah MischLLM1
Reviewer
Noah Mischcommitter2
Robert Haas2
Tom Lane1
Reported by
Alexander Lakhin2
Committer
Noah Misch5

N LLM means N of the credits come from LLM analysis, not from commit trailers.