Aug 2025

9 commits
Use consistent type for pgaio_io_get_id() result
21 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1REL_18_STABLE18rc1
LLM analysis, 99% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The changes to aio_funcs.c and method_worker.c match #4, including int handle IDs and the -1 sentinel. The only substantive diff-context adjustment replaces an intervening UInt32GetDatum(ioh_id) conversion with the originally proposed Int32GetDatum(ioh_id).

  • Andres Freundsaw the final versiontrailerAndres accepted the AIO patch in #10, noting that unsigned IDs were another reasonable choice.
Mop-up for Datum conversion cleanups.
8 Aug 2025Tom Lanemaster19beta1REL_19_STABLE19beta1Also in: Making type Datum be 8 bytes everywhere (not this thread)
LLM analysis, 98% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Tom announced the missing DatumGetPointer conversions and replacement of (Datum) NULL with (Datum) 0 in #12; the overlapping experimental hunks in #1 instead use .value and DummyDatum. The supplied verdict for thread #51944 confirms this attribution and identifies no matching attachment there.

  • Andres Freundsaw an earlier versionLLM analysis, 87% sureAndres identified a missing DatumGet conversion while reviewing the struct experiment in #11, which Tom acknowledged in #12 before implementing the broader cleanup.
Add missing Datum conversions
8 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

This lands most of the missing-conversion patch from #1, omitting the _int_matchsel(), numeric-distance return, and att_addlength_datum() hunks. Retained code matches apart from removal of the AIO XXX comment.

  • Tom Lanesaw the final versiontrailerTom reviewed the missing conversions in #2, proposed avoiding a float8 round trip, and identified the separate intarray bug in #7.
Remove useless/superfluous Datum conversions
8 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

This retains the superfluous-conversion cleanup from #1 while omitting its range_send(), multirange_send(), and timestamptz_trunc_internal() hunks. The remaining changes match the attachment.

  • Tom Lanesaw the final versiontrailerTom reviewed and endorsed the conversion cleanups in #2, and the retained hunks landed unchanged.
Fix incorrect lack of Datum conversion in _int_matchsel()
8 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1REL_18_STABLE18beta3REL_17_STABLE17.6REL_16_STABLE16.10REL_15_STABLE15.14REL_14_STABLE14.19REL_13_STABLE13.22
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

The single _int_matchsel() hunk in contrib/intarray/_int_selfuncs.c exactly matches #1, replacing return (Selectivity) 0.0 with PG_RETURN_FLOAT8(0.0). It was isolated for backpatching after #7 identified the potential 32-bit failure.

  • Tom Lanesaw the final versiontrailerTom identified the possible null-pointer failure in #7 and then established that the empty-query branch was unreachable in #8.
Improve tests of date_trunc() with infinity and unsupported units
7 Aug 2025Michael Paquiermaster19beta1REL_19_STABLE19beta1REL_18_STABLE18beta3Also in: date_trunc invalid units with infinite value (modified before commit)
Fix incorrect Datum conversion in timestamptz_trunc_internal()
7 Aug 2025Michael Paquiermaster19beta1REL_19_STABLE19beta1REL_18_STABLE18beta3Also in: date_trunc invalid units with infinite value (landed as posted)
Fix various hash function uses
5 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

All changes match the hash-function patch in #1, replacing Datum-returning hash functions with hash_bytes() or hash_bytes_uint32() across six files.

  • Tom Lanesaw the final versiontrailerTom explicitly reported no objection to the hash-function cleanup after reviewing the series in #2.
Fix mixups of FooGetDatum() vs. DatumGetFoo()
5 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

All nine conversion-direction corrections across five files match the first patch in #1, including pageinspect, nbtcompare.c, printsimple.c, and xlog.c.

  • Tom Lanesaw the final versiontrailerTom reviewed the series in #2 and recommended committing the conversion-direction corrections.

Credits across 9 commits

Author
Peter Eisentraut6 LLM8
Reviewer
Tom Lane6
Michael Paquiercommitter2
Andres Freund1
Committer
Peter Eisentraut6
Michael Paquier2
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.