Aug 2025

4 commits
Silence -Wmissing-variable-declarations in headerscheck.
29 Aug 2025Tom Lanemaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #10 of 1 reviewer saw the final version

The commit retains all three changed files and the extern-declaration approach from #1, revising comments and adding PGDLLIMPORT to the declaration generated by src/tools/gen_keywordlist.pl. The latter is a platform-relevant declaration change beyond Peter's requested comment clarification #7.

  • Peter Eisentrautsaw an earlier versiontrailerPeter accepted the extern approach and requested clearer comments in #7, but the committed generator additionally introduced PGDLLIMPORT without a visible review of that change.
headerscheck: Document that --with-llvm is required
29 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

The commit adds --with-llvm to both configuration examples in src/tools/pginclude/README, implementing Tom's suggestion in #5. No attached patch makes this documentation change; #4 instead proposed skipping llvmjit_backport.h.

  • Tom Lanesaw an earlier versionLLM analysis, 99% sureTom rejected the LLVM header exclusion in #4 and proposed documenting --with-llvm in #5, replacing the exclusion approach; the commit credits him as Suggested-by.
headerscheck: Use ICU_CFLAGS
29 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #41 of 1 reviewer saw the final version

The commit takes only the ICU_CFLAGS component of #4, preserving both hunks in src/tools/pginclude/headerscheck exactly: read ICU_CFLAGS and include it in the C and C++ compiler flags.

  • Tom Lanesaw the final versiontrailerTom approved the ICU_CFLAGS fix in #5, explaining that empty ICU_CFLAGS in his environment had hidden the omission.
headerscheck: Ignore Windows-specific header
29 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #41 of 1 reviewer saw the final version

The commit takes only the Windows-header component of the four-patch series #4, preserving its one-line change in src/tools/pginclude/headerscheck exactly: skip port/win32/sys/resource.h for C as well as C++.

  • Tom Lanesaw the final versiontrailerTom explicitly endorsed the Windows-header exclusion in #5, and that component landed unchanged.

Credits across 4 commits

Author
Peter EisentrautLLM2
Tom Lane1
Reviewer
Tom Lane2
Peter Eisentraut1
Committer
Peter Eisentraut3
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.