model-writtenrun 1964 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Andres Freund reported that recent GCC warned about maxsize being set but unused in SerializeClientConnectionInfo() when assertions were disabled, and proposed using PG_USED_FOR_ASSERTS_ONLY on the parameter #1.
- Jacob Champion supported the annotation but raised strengthening the assertion into a runtime error; Andres agreed that this would be reasonable outside a hot path, while Jacob preferred the annotation for backpatching #2 #4 #5.
- Michael Paquier reported that preliminary build testing supported using the annotation, despite an unrelated Windows libpq failure, and identified conditional compilation as a fallback if portability problems emerged #3.
- Michael submitted a patch annotating both the declaration and definition; Andres requested restricting the attribute to the definition because it describes implementation details, and Jacob endorsed that adjustment #7 #8 #9.
- Michael committed the patch with the declaration change removed as 6304256e79, with backpatching through PostgreSQL 16, and confirmed the definition-only change #10.
- The warning fix was complete at the thread's end, while Jacob left the assertion-versus-runtime-error question for future work behind other priorities #11.