Fix typos in comments in worker.c and execReplication.c

Started by Tender Wang5 months ago2 messages
#1Tender Wang
tndrwang@gmail.com
1 attachment(s)

Hi,

While debugging the code, I found typos in worker.c and execReplication.c

"suffcient" should be "sufficient"
"confict" should be "conflict"

fd5a1a0 introduced these typos.
Please take a look at the attached patch.
--
Thanks,
Tender Wang

Attachments:

0001-Fix-typos-in-comments-in-worker.c-and-execReplicatio.patchtext/plain; charset=US-ASCII; name=0001-Fix-typos-in-comments-in-worker.c-and-execReplicatio.patchDownload
From 6b40fae3d09755d497e79ce3895308e44fd6c9fb Mon Sep 17 00:00:00 2001
From: Tender Wang <tndrwang@gmail.com>
Date: Sat, 16 Aug 2025 15:34:03 +0800
Subject: [PATCH] Fix typos in comments in worker.c and execReplication.c

---
 src/backend/executor/execReplication.c   | 2 +-
 src/backend/replication/logical/worker.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/backend/executor/execReplication.c b/src/backend/executor/execReplication.c
index 68184f5d671..da0cbf41d6f 100644
--- a/src/backend/executor/execReplication.c
+++ b/src/backend/executor/execReplication.c
@@ -582,7 +582,7 @@ RelationFindDeletedTupleInfoSeq(Relation rel, TupleTableSlot *searchslot,
 	 * IsIndexUsableForFindingDeletedTuple), a full table scan becomes
 	 * necessary. In such cases, comparing the entire tuple is not required,
 	 * since the remote tuple might not include all column values. Instead,
-	 * the indexed columns alone are suffcient to identify the target tuple
+	 * the indexed columns alone are sufficient to identify the target tuple
 	 * (see logicalrep_rel_mark_updatable).
 	 */
 	indexbitmap = RelationGetIndexAttrBitmap(rel,
diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c
index 59b6ae7719a..8e343873454 100644
--- a/src/backend/replication/logical/worker.c
+++ b/src/backend/replication/logical/worker.c
@@ -2923,7 +2923,7 @@ apply_handle_update_internal(ApplyExecutionData *edata,
 
 		/*
 		 * Detecting whether the tuple was recently deleted or never existed
-		 * is crucial to avoid misleading the user during confict handling.
+		 * is crucial to avoid misleading the user during conflict handling.
 		 */
 		if (FindDeletedTupleInLocalRel(localrel, localindexoid, remoteslot,
 									   &conflicttuple.xmin,
@@ -3392,7 +3392,7 @@ apply_handle_tuple_routing(ApplyExecutionData *edata,
 					/*
 					 * Detecting whether the tuple was recently deleted or
 					 * never existed is crucial to avoid misleading the user
-					 * during confict handling.
+					 * during conflict handling.
 					 */
 					if (FindDeletedTupleInLocalRel(partrel,
 												   part_entry->localindexoid,
-- 
2.34.1

#2Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Tender Wang (#1)
Re: Fix typos in comments in worker.c and execReplication.c

On Sat, Aug 16, 2025 at 12:44 AM Tender Wang <tndrwang@gmail.com> wrote:

Hi,

While debugging the code, I found typos in worker.c and execReplication.c

"suffcient" should be "sufficient"
"confict" should be "conflict"

fd5a1a0 introduced these typos.
Please take a look at the attached patch.

Thank you for the patch! I've just pushed it.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com