test_ddl_deparse: Rename test create_sequence_1
Hi all,
While looking at this area of the code, I got confused by the choice
of using create_sequence_1 as name for one of the scripts in the test
module test_ddl_deparse. This is usually reserved for alternate
outputs, but we don't need to rely on that in this case.
How about renaming the test as per the attached?
Thanks,
--
Michael
Attachments:
0001-test_ddl_deparse-create_sequence_1-create_sequence.patchtext/x-diff; charset=us-asciiDownload
From 6d2f61a35799338a2953986707e4658dd4ecfe9d Mon Sep 17 00:00:00 2001
From: Michael Paquier <michael@paquier.xyz>
Date: Mon, 18 Aug 2025 16:35:19 +0900
Subject: [PATCH] test_ddl_deparse: create_sequence_1 => create_sequence
---
src/test/modules/test_ddl_deparse/Makefile | 2 +-
.../expected/{create_sequence_1.out => create_sequence.out} | 0
src/test/modules/test_ddl_deparse/meson.build | 2 +-
.../sql/{create_sequence_1.sql => create_sequence.sql} | 0
4 files changed, 2 insertions(+), 2 deletions(-)
rename src/test/modules/test_ddl_deparse/expected/{create_sequence_1.out => create_sequence.out} (100%)
rename src/test/modules/test_ddl_deparse/sql/{create_sequence_1.sql => create_sequence.sql} (100%)
diff --git a/src/test/modules/test_ddl_deparse/Makefile b/src/test/modules/test_ddl_deparse/Makefile
index 3a57a95c8496..6a9c133ebe97 100644
--- a/src/test/modules/test_ddl_deparse/Makefile
+++ b/src/test/modules/test_ddl_deparse/Makefile
@@ -13,7 +13,7 @@ REGRESS = test_ddl_deparse \
create_type \
create_conversion \
create_domain \
- create_sequence_1 \
+ create_sequence \
create_table \
create_transform \
alter_table \
diff --git a/src/test/modules/test_ddl_deparse/expected/create_sequence_1.out b/src/test/modules/test_ddl_deparse/expected/create_sequence.out
similarity index 100%
rename from src/test/modules/test_ddl_deparse/expected/create_sequence_1.out
rename to src/test/modules/test_ddl_deparse/expected/create_sequence.out
diff --git a/src/test/modules/test_ddl_deparse/meson.build b/src/test/modules/test_ddl_deparse/meson.build
index bff65ba6333d..e60aee3b1d3b 100644
--- a/src/test/modules/test_ddl_deparse/meson.build
+++ b/src/test/modules/test_ddl_deparse/meson.build
@@ -33,7 +33,7 @@ tests += {
'create_type',
'create_conversion',
'create_domain',
- 'create_sequence_1',
+ 'create_sequence',
'create_table',
'create_transform',
'alter_table',
diff --git a/src/test/modules/test_ddl_deparse/sql/create_sequence_1.sql b/src/test/modules/test_ddl_deparse/sql/create_sequence.sql
similarity index 100%
rename from src/test/modules/test_ddl_deparse/sql/create_sequence_1.sql
rename to src/test/modules/test_ddl_deparse/sql/create_sequence.sql
--
2.50.0
Hi!
On Mon, 18 Aug 2025 at 12:40, Michael Paquier <michael@paquier.xyz> wrote:
Hi all,
While looking at this area of the code, I got confused by the choice
of using create_sequence_1 as name for one of the scripts in the test
module test_ddl_deparse. This is usually reserved for alternate
outputs, but we don't need to rely on that in this case.
I did not find any related discussion or objections in the thread [0]/messages/by-id/20150508192921.GM2523@alvh.no-ip.org,
so this is probably an oversight of b488c58.
Also, do we have any doc about regression file names/alternate
outputs? I did not find any.
[0]: /messages/by-id/20150508192921.GM2523@alvh.no-ip.org
--
Best regards,
Kirill Reshke
On Mon, Aug 18, 2025 at 02:05:20PM +0500, Kirill Reshke wrote:
Also, do we have any doc about regression file names/alternate
outputs? I did not find any.
You have missed this one:
https://www.postgresql.org/docs/devel/regress-variant.html
--
Michael