Sep 2025

2 commits
Remove dynahash.h
10 Sep 2025Michael Paquiermaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #161 of 2 reviewers saw the final version

The commit exactly matches the second patch in #16: delete src/include/utils/dynahash.h, remove its include, and make my_log2 static in src/backend/utils/hash/dynahash.c.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 94% sureIn #13, he advocated keeping custom bounded helpers local to dynahash.c, which informed the later approach of retaining my_log2 privately while deleting its header.
  • Dean Rasheedsaw the final versionLLM analysis, 98% sureHe proposed avoiding new bounded helpers in #15 and endorsed the resulting series in #17, with his remaining objection confined to the separate caller-conversion patch.
Replace callers of dynahash.h's my_log() by equivalent in pg_bitutils.h
10 Sep 2025Michael Paquiermaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #161 of 2 reviewers saw the final version

Matches the first patch in #16 except that the added bucket cap in src/backend/executor/nodeHash.c is removed, following Dean Rasheed's analysis in #17 and Michael Paquier's confirmation in #18.

  • Peter Eisentrautsaw an earlier versiontrailerHe challenged the widened 32-bit API in #11 and custom bounded helpers in #13, before the substantial switch to existing pg_bitutils.h functions.
  • Dean Rasheedsaw the final versiontrailerHe proposed moving bounds to callers in #15, then demonstrated in #17 that the new bucket cap was incorrect and unnecessary, producing the committed correction.

Aug 2025

1 commit
Change dynahash.c and hsearch.h to use int64 instead of long
22 Aug 2025Michael Paquiermaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #52 of 2 reviewers saw the final version

All nine files match #5, with only whitespace alignment differing in ShmemInitHash's parameter comments; #10 confirms the long-to-int64 conversion was applied.

  • Peter Eisentrautsaw the final versiontrailerHe questioned the unsigned conversion in #4 and subsequently examined the committed int64 version in #13, asking whether its counters actually required that range.
  • Chao Lisaw the final versiontrailerHe found the accidental comment replacement in #2, discussed helper naming in #6, and agreed in #8 to proceed with the conversion separately.

Credits across 3 commits

Author
Michael PaquierLLM3
Reviewer
Peter Eisentraut2
Chao Li1
Dean Rasheed1
Committer
Michael Paquier3

N LLM means N of the credits come from LLM analysis, not from commit trailers.