Move block_range_read_stream_cb batchmode comment
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t52202psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 20, 2026 at 03:04 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t52202_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t52202_1 && git checkout t52202_1Patchset v1 (message #1) is on t52202_1
Hi,
Currently, each usage of block_range_read_stream_cb is accompanied by
the same comment about the safety of using batchmode (there are 7
identical comments)
/*
* It is safe to use batchmode as block_range_read_stream_cb takes no
* locks.
*/
The idea is to write it once near block_range_read_stream_cb and drop
all duplicates. PFA the small patch that does this.
Best regards,
Arseniy Mukhin
Hi,
On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote:
Currently, each usage of block_range_read_stream_cb is accompanied by
the same comment about the safety of using batchmode (there are 7
identical comments)
-1 - I think it's better to have the analysis at the point of using the flag
and callback, as otherwise it's too easy to change the callsites to a
different callback, without removing the flag.
Greetings,
Andres Freund
On Sat, Aug 30, 2025 at 9:14 PM Andres Freund <andres@anarazel.de> wrote:
Hi,
On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote:
Currently, each usage of block_range_read_stream_cb is accompanied by
the same comment about the safety of using batchmode (there are 7
identical comments)-1 - I think it's better to have the analysis at the point of using the flag
and callback, as otherwise it's too easy to change the callsites to a
different callback, without removing the flag.
Got the idea, thank you for the explanation.
Best regards,
Arseniy Mukhin