Move block_range_read_stream_cb batchmode comment
Hi,
Currently, each usage of block_range_read_stream_cb is accompanied by
the same comment about the safety of using batchmode (there are 7
identical comments)
/*
* It is safe to use batchmode as block_range_read_stream_cb takes no
* locks.
*/
The idea is to write it once near block_range_read_stream_cb and drop
all duplicates. PFA the small patch that does this.
Best regards,
Arseniy Mukhin
Attachments:
v1-0001-Moves-the-comment-about-block_range_read_stream_c.patchtext/x-patch; charset=US-ASCII; name=v1-0001-Moves-the-comment-about-block_range_read_stream_c.patchDownload+2-30
Hi,
On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote:
Currently, each usage of block_range_read_stream_cb is accompanied by
the same comment about the safety of using batchmode (there are 7
identical comments)
-1 - I think it's better to have the analysis at the point of using the flag
and callback, as otherwise it's too easy to change the callsites to a
different callback, without removing the flag.
Greetings,
Andres Freund
On Sat, Aug 30, 2025 at 9:14 PM Andres Freund <andres@anarazel.de> wrote:
Hi,
On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote:
Currently, each usage of block_range_read_stream_cb is accompanied by
the same comment about the safety of using batchmode (there are 7
identical comments)-1 - I think it's better to have the analysis at the point of using the flag
and callback, as otherwise it's too easy to change the callsites to a
different callback, without removing the flag.
Got the idea, thank you for the explanation.
Best regards,
Arseniy Mukhin