model-writtenrun 7012 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed removing PointerIsValid() because ordinary pointer checks serve the same purpose, also removing several unused or rarely used related macros while retaining HeapTupleIsValid(), ItemIdIsValid(), PortalIsValid(), and RelationIsValid() to limit churn #1.
- Chao Li favored consistently using explicit NULL comparisons #2, Peter Geoghegan supported removal and that preference #3, and Robert Haas recommended allowing direct pointer tests where surrounding code uses them #4, followed by Nathan Bossart's agreement #5.
- Jacob Champion reviewed the patch, approved its existing mixture of styles, and opposed standardizing exclusively on explicit comparisons #6.
- David Rowley preferred explicit NULL comparisons with exceptions for surrounding style #7, while Michael Paquier supported removal and found the affected locations unproblematic #8.
- Peter Eisentraut committed the original patch #1 unchanged as a5b35fcedb, then confirmed completion and left any specific stylistic adjustments for possible follow-up patches #9.