mislead comments in pg_get_statisticsobjdef_string

Started by jian he4 months ago2 messages
#1jian he
jian.universality@gmail.com

hi.

/*
* Internal version for use by ALTER TABLE.
* Includes a tablespace clause in the result.
* Returns a palloc'd C string; no pretty-printing.
*/
char *
pg_get_statisticsobjdef_string(Oid statextid)
{
return pg_get_statisticsobj_worker(statextid, false, false);
}

is the above "tablespace clause" comment wrong?
since there is no "tablespace clause" related to CREATE STATISTICS.

I guess that time, comments were just simply copied from
function pg_get_indexdef_string.

#2David Rowley
dgrowleyml@gmail.com
In reply to: jian he (#1)
Re: mislead comments in pg_get_statisticsobjdef_string

On Fri, 26 Sept 2025 at 01:17, jian he <jian.universality@gmail.com> wrote:

* Internal version for use by ALTER TABLE.
* Includes a tablespace clause in the result.
* Returns a palloc'd C string; no pretty-printing.
*/
char *
pg_get_statisticsobjdef_string(Oid statextid)
{
return pg_get_statisticsobj_worker(statextid, false, false);
}

is the above "tablespace clause" comment wrong?

Yes

since there is no "tablespace clause" related to CREATE STATISTICS.

I guess that time, comments were just simply copied from
function pg_get_indexdef_string.

I expect you're correct. I've pushed a fix. Thanks

David