Wordsmith pgstat_relation.c header comment

Started by Bertrand Drouvot3 months ago2 messages
#1Bertrand Drouvot
bertranddrouvot.pg@gmail.com
1 attachment(s)

Hi hackers,

I was working on statistics and realized that the pgstat_relation.c header comment
is mentioning "function relation" which does not look appropriate and probably a
typo or copy/paste error in 13619598f108.

PFA a tiny patch to use "relation statistics" instead, which is more consistent
with other pgstat_*.c files header comments.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachments:

v1-0001-Wordsmith-pgstat_relation.c-header-comment.patchtext/x-diff; charset=us-asciiDownload
From fbcc86b858894964a775695a84d09fe7501b78e4 Mon Sep 17 00:00:00 2001
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Date: Tue, 30 Sep 2025 08:37:10 +0000
Subject: [PATCH v1] Wordsmith pgstat_relation.c header comment

The comment was mentioning "function relation" which does not look appropriate
and probably a typo or copy/paste error in 13619598f108.

Use "relation statistics" instead which is more consistent with other
pgstat_*.c files header comments.
---
 src/backend/utils/activity/pgstat_relation.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_relation.c b/src/backend/utils/activity/pgstat_relation.c
index 69df741cbf6..b5e3903a290 100644
--- a/src/backend/utils/activity/pgstat_relation.c
+++ b/src/backend/utils/activity/pgstat_relation.c
@@ -3,7 +3,7 @@
  * pgstat_relation.c
  *	  Implementation of relation statistics.
  *
- * This file contains the implementation of function relation. It is kept
+ * This file contains the implementation of relation statistics. It is kept
  * separate from pgstat.c to enforce the line between the statistics access /
  * storage implementation and the details about individual types of
  * statistics.
-- 
2.34.1

#2David Rowley
dgrowleyml@gmail.com
In reply to: Bertrand Drouvot (#1)
Re: Wordsmith pgstat_relation.c header comment

On Tue, 30 Sept 2025 at 21:52, Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:

I was working on statistics and realized that the pgstat_relation.c header comment
is mentioning "function relation" which does not look appropriate and probably a
typo or copy/paste error in 13619598f108.

Yeah, looks like maybe someone pasted the "relation" over the wrong
word after a copy/paste from pgstat_function.c.

Pushed.

David