Fix incorrect function reference BufFileOpenShared in comment.
Hi,
The comment incorrectly cited the defunct function BufFileOpenShared()
which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.
Update the reference to the current function: BufFileOpenFileSet().
--
Zhang Mingli
HashData
Attachments:
v0-0001-Fix-incorrect-function-reference-in-comment.patchapplication/octet-streamDownload
From 95af858d2a9bc2365add7e5ee2afbd6ec2f7a881 Mon Sep 17 00:00:00 2001
From: Zhang Mingli <avamingli@gmail.com>
Date: Wed, 1 Oct 2025 16:09:59 +0800
Subject: [PATCH] Fix incorrect function reference in comment.
The comment incorrectly cited the defunct function BufFileOpenShared()
which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.
Update the reference to the current function: BufFileOpenFileSet().
Authored-by: Zhang Mingli avamingli@gmail.com
---
src/backend/utils/sort/logtape.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/utils/sort/logtape.c b/src/backend/utils/sort/logtape.c
index e529ceb826..452d89a8c0 100644
--- a/src/backend/utils/sort/logtape.c
+++ b/src/backend/utils/sort/logtape.c
@@ -681,7 +681,7 @@ LogicalTapeCreate(LogicalTapeSet *lts)
{
/*
* The only thing that currently prevents creating new tapes in leader is
- * the fact that BufFiles opened using BufFileOpenShared() are read-only
+ * the fact that BufFiles opened using BufFileOpenFileSet() are read-only
* by definition, but that could be changed if it seemed worthwhile. For
* now, writing to the leader tape will raise a "Bad file descriptor"
* error, so tuplesort must avoid writing to the leader tape altogether.
--
2.34.1
Import Notes
Reply to msg id not found: e5285739-47b9-4128-ad83-1a06bccfd1ca@SparkReference msg id not found: e5285739-47b9-4128-ad83-1a06bccfd1ca@Spark
Thank you for your path ,The path LGTM
On Wed, 1 Oct 2025 at 16:15, Zhang Mingli <zmlpostgres@gmail.com> wrote:
Show quoted text
Hi,
The comment incorrectly cited the defunct function BufFileOpenShared()
which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.Update the reference to the current function: BufFileOpenFileSet().
--
Zhang Mingli
HashData
On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
The comment incorrectly cited the defunct function BufFileOpenShared()
which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.Update the reference to the current function: BufFileOpenFileSet().
Nice catch. Running `git grep 'BufFile.*Shared'` confirms that this
is the only place referencing the outdated BufFileXXXShared()
functions. I'll push this patch barring any objections.
- Richard
On Wed, Oct 1, 2025 at 6:29 PM Richard Guo <guofenglinux@gmail.com> wrote:
On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
The comment incorrectly cited the defunct function BufFileOpenShared()
which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.Update the reference to the current function: BufFileOpenFileSet().
Nice catch. Running `git grep 'BufFile.*Shared'` confirms that this
is the only place referencing the outdated BufFileXXXShared()
functions. I'll push this patch barring any objections.
Pushed.
- Richard
Thanks.
Richard Guo <guofenglinux@gmail.com>于2025年10月3日 周五15:41写道:
Show quoted text
On Wed, Oct 1, 2025 at 6:29 PM Richard Guo <guofenglinux@gmail.com> wrote:
On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres@gmail.com>
wrote:
The comment incorrectly cited the defunct function BufFileOpenShared()
which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.Update the reference to the current function: BufFileOpenFileSet().
Nice catch. Running `git grep 'BufFile.*Shared'` confirms that this
is the only place referencing the outdated BufFileXXXShared()
functions. I'll push this patch barring any objections.Pushed.
- Richard