model-writtenrun 1759 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed removing redundant restrict-qualified casts and replacing pg_restrict with standard restrict in #1, retaining build-system indirection to support C++ because MSVC's C11 support appeared to make the workaround unnecessary.
- Tom Lane warned that removing pg_restrict would break extensions and requested a compatibility definition while accepting the internal spelling change in #2.
- The cast cleanup landed unchanged as 64d2b0968e, and the keyword replacement landed with the requested compatibility definition and comment edits as f0f2c0c1ae; Peter confirmed completion in #3.
- Jelte Fennema-Nio reported in #4 that the replacement broke MSVC C++ extension builds by changing system-header __declspec(restrict) into __declspec(__restrict), and Andres Freund supported reverting it in #5.
- Peter proposed a compiler test or conditional definition of restrict in #6, but Jelte explained in #7 that any macro replacement would corrupt MSVC's existing __declspec(restrict) syntax, making restoration of pg_restrict necessary.
- Peter reverted the keyword replacement in fa16e7fd84 and confirmed in #8 that the comments now identify C++ as the remaining reason for the workaround; the independent cast cleanup remains committed.