Remove an unnecessary blank line on the PQisBusy() comments
Hi,
I’ve attached a very trivial patch that removes an unnecessary line
after the comments on PQisBusy(), just for consistency with the
surrounding code.
Regards,
Yugo Nagata
--
Yugo Nagata <nagata@sraoss.co.jp>
Attachments:
remove_unnecessary_blank_line.patchtext/x-diff; name=remove_unnecessary_blank_line.patchDownload
diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
index 0b1e37ec30b..f885907607d 100644
--- a/src/interfaces/libpq/fe-exec.c
+++ b/src/interfaces/libpq/fe-exec.c
@@ -2037,7 +2037,6 @@ parseInput(PGconn *conn)
* PQisBusy
* Return true if PQgetResult would block waiting for input.
*/
-
int
PQisBusy(PGconn *conn)
{
On Thu, Oct 23, 2025 at 08:02:03PM +0900, Yugo Nagata wrote:
I’ve attached a very trivial patch that removes an unnecessary line
after the comments on PQisBusy(), just for consistency with the
surrounding code.
Given this line has been there for 28 years (commit edbd513) and isn't
hurting anything, I don't see a strong need to change it.
--
nathan
On Thu, Oct 23, 2025, at 12:11 PM, Nathan Bossart wrote:
On Thu, Oct 23, 2025 at 08:02:03PM +0900, Yugo Nagata wrote:
I’ve attached a very trivial patch that removes an unnecessary line
after the comments on PQisBusy(), just for consistency with the
surrounding code.Given this line has been there for 28 years (commit edbd513) and isn't
hurting anything, I don't see a strong need to change it.
In this same file there are other cases of blank line after comment and before
function definition. If, in the future, we have an automated tool (pgindent?)
that removes such blank line(s) after comment and before function definition, I
would say fix it. That's not the case; I would leave it alone.
--
Euler Taveira
EDB https://www.enterprisedb.com/
On Thu, 23 Oct 2025 12:19:03 -0300
"Euler Taveira" <euler@eulerto.com> wrote:
On Thu, Oct 23, 2025, at 12:11 PM, Nathan Bossart wrote:
On Thu, Oct 23, 2025 at 08:02:03PM +0900, Yugo Nagata wrote:
I’ve attached a very trivial patch that removes an unnecessary line
after the comments on PQisBusy(), just for consistency with the
surrounding code.Given this line has been there for 28 years (commit edbd513) and isn't
hurting anything, I don't see a strong need to change it.In this same file there are other cases of blank line after comment and before
function definition. If, in the future, we have an automated tool (pgindent?)
that removes such blank line(s) after comment and before function definition, I
would say fix it. That's not the case; I would leave it alone.
Thank you for taking a look at it.
I was just wondering about it, and agree that there's no need to remove it at
this point since it’s harmless.
Regards,
Yugo Nagata
--
Yugo Nagata <nagata@sraoss.co.jp>