Avoid resource leak (src/bin/pg_resetwal/pg_resetwal.c)

Started by Ranier Vilela11 months ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t52526
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 20, 2026 at 09:29 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t52526_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t52526_1 && git checkout t52526_1

Patchset v1 (message #1) is on t52526_1

Jump to latest
#1Ranier Vilela
ranier.vf@gmail.com

Hi.

Per Coverity.

The function *read_controlfile* is responsible for updating old pg_control
versions.
Coverity complains that the struct ControlFileData buffer is leaked.

I think that is right.

Trivial patch attached.

best regards,
Ranier Vilela

Attachments:

t52526_1
avoid-resource-leak-pg_resetwal.patchapplication/octet-stream; name=avoid-resource-leak-pg_resetwal.patchDownload+3-0
#2Michael Paquier
michael@paquier.xyz
In reply to: Ranier Vilela (#1)
Re: Avoid resource leak (src/bin/pg_resetwal/pg_resetwal.c)

On Thu, Oct 23, 2025 at 09:26:24PM -0300, Ranier Vilela wrote:

The function *read_controlfile* is responsible for updating old pg_control
versions.
Coverity complains that the struct ControlFileData buffer is leaked.

I think that is right.

Bis repetita. Allocation in the context of a short-term binary
execution.
--
Michael