Avoid resource leak (src/bin/pg_resetwal/pg_resetwal.c)

Started by Ranier Vilela6 months ago2 messageshackers
Jump to latest
#1Ranier Vilela
ranier.vf@gmail.com

Hi.

Per Coverity.

The function *read_controlfile* is responsible for updating old pg_control
versions.
Coverity complains that the struct ControlFileData buffer is leaked.

I think that is right.

Trivial patch attached.

best regards,
Ranier Vilela

Attachments:

avoid-resource-leak-pg_resetwal.patchapplication/octet-stream; name=avoid-resource-leak-pg_resetwal.patchDownload+3-0
#2Michael Paquier
michael@paquier.xyz
In reply to: Ranier Vilela (#1)
Re: Avoid resource leak (src/bin/pg_resetwal/pg_resetwal.c)

On Thu, Oct 23, 2025 at 09:26:24PM -0300, Ranier Vilela wrote:

The function *read_controlfile* is responsible for updating old pg_control
versions.
Coverity complains that the struct ControlFileData buffer is leaked.

I think that is right.

Bis repetita. Allocation in the context of a short-term binary
execution.
--
Michael