Unused variable in perl test

Started by Daniil Davydov6 months ago3 messageshackers
Jump to latest
#1Daniil Davydov
3danissimo@gmail.com

Hi, here is my 2c :)

There is an unused variable "backup_name" in
test/recovery/t/006_logical_decoding.pl
What about getting rid of it?

--
Best regards,
Daniil Davydov

Attachments:

0001-Get-rid-of-unused-variable.patchtext/x-patch; charset=US-ASCII; name=0001-Get-rid-of-unused-variable.patchDownload+0-2
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Daniil Davydov (#1)
Re: Unused variable in perl test

On 24 Oct 2025, at 16:12, Daniil Davydov <3danissimo@gmail.com> wrote:

There is an unused variable "backup_name" in
test/recovery/t/006_logical_decoding.pl
What about getting rid of it?

Seems to have been unused since introduced in d851bef2d60ff close to a decade
ago.

--
Daniel Gustafsson

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Daniel Gustafsson (#2)
Re: Unused variable in perl test

Daniel Gustafsson <daniel@yesql.se> writes:

On 24 Oct 2025, at 16:12, Daniil Davydov <3danissimo@gmail.com> wrote:

There is an unused variable "backup_name" in
test/recovery/t/006_logical_decoding.pl
What about getting rid of it?

Seems to have been unused since introduced in d851bef2d60ff close to a decade
ago.

I didn't double-check the history, but it's clearly unused now.
Pushed.

regards, tom lane