Nov 2025

2 commits
Fix "inconsistent DLL linkage" warning on Windows MSVC
7 Nov 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #12 of 2 reviewers saw the final version

a3ea5330fc lands the complete second patch of the two-patch series in #1; all four file diffs match after excluding blob IDs. The commit message replaces the compatibility uncertainty with the conclusion that MSVC no longer supports the old MSVCRT library.

  • Bryan Greensaw the final versiontrailerIn #2, Bryan explained the MSVCRT/UCRT environ ABI difference and supported removing the MSVC condition if supported toolchains use UCRT.
  • Andres Freundsaw the final versiontrailerIn #5, Andres confirmed that recent MSVC versions no longer use MSVCRT, resolving the compatibility concern behind the declaration changes.
MSVC: Improve warning options set
6 Nov 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

2307cfe316 lands the complete first patch of the two-patch series in #1. Its meson.build diff matches exactly after excluding blob IDs; the DLL-linkage fix lands separately.

  • Bryan Greensaw the final versiontrailerIn #2, Bryan endorsed organizing warnings by level and explicitly agreed with enabling the unreferenced-label warning.

Credits across 2 commits

Author
Peter EisentrautLLM2
Reviewer
Bryan Green2
Andres Freund1
Committer
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.