Obsolete comment in ExecScanReScan()
While working on a patch to add more test coverage for EPQ testing
posted right before, I noticed $SUBJECT:
/*
* If an FDW or custom scan provider has replaced the join with a
* scan, there are multiple RTIs; reset the epqScanDone flag for
* all of them.
*/
We removed epqScanDone and instead added relsubs_done in commit
27cc7cd2b, so the second part of the comment should be something like
this: "reset the relsubs_done flag for all of them." Attached is a
patch for that.
Best regards,
Etsuro Fujita
Attachments:
Update-obsolete-comment-in-ExecScanReScan.patchapplication/octet-stream; name=Update-obsolete-comment-in-ExecScanReScan.patchDownload
diff --git a/src/backend/executor/execScan.c b/src/backend/executor/execScan.c
index 90726949a87..31ed4783c1d 100644
--- a/src/backend/executor/execScan.c
+++ b/src/backend/executor/execScan.c
@@ -134,7 +134,7 @@ ExecScanReScan(ScanState *node)
/*
* If an FDW or custom scan provider has replaced the join with a
- * scan, there are multiple RTIs; reset the epqScanDone flag for
+ * scan, there are multiple RTIs; reset the relsubs_done flag for
* all of them.
*/
if (IsA(node->ps.plan, ForeignScan))
On Sat, Nov 1, 2025 at 8:25 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
While working on a patch to add more test coverage for EPQ testing
posted right before, I noticed $SUBJECT:/*
* If an FDW or custom scan provider has replaced the join with a
* scan, there are multiple RTIs; reset the epqScanDone flag for
* all of them.
*/We removed epqScanDone and instead added relsubs_done in commit
27cc7cd2b, so the second part of the comment should be something like
this: "reset the relsubs_done flag for all of them." Attached is a
patch for that.
Pushed and back-patched.
Best regards,
Etsuro Fujita