Minor refactor of the code in ExecScanExtended()

On Sun, Jan 18, 2026 at 7:31 PM cca5507 <cca5507@qq.com> wrote:

Hi,

The current code:

if (!qual && !projInfo)
{
ResetExprContext(econtext);
return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
}

ResetExprContext(econtext);

The following format might be simpler:

ResetExprContext(econtext);

if (!qual && !projInfo)
return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);

Attach a patch to do this.

--
Regards,
ChangAo Chen

Hi,

+1, seems like a simple refactor.
Tests are passing locally for me!

- Adi Gollamudi

Hi hackers,

2026년 1월 19일 (월) PM 1:51, Aditya Gollamudi <adigollamudi@gmail.com>님이 작성:

On Sun, Jan 18, 2026 at 7:31 PM cca5507 <cca5507@qq.com> wrote:

Hi,

The current code:

if (!qual && !projInfo)
{
ResetExprContext(econtext);
return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
}

ResetExprContext(econtext);

The following format might be simpler:

ResetExprContext(econtext);

if (!qual && !projInfo)
return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);

Attach a patch to do this.

--
Regards,
ChangAo Chen

Hi,

+1, seems like a simple refactor.
Tests are passing locally for me!

- Adi Gollamudi

+1, agreed.

The refactored version is cleaner and easier to read by moving
ResetExprContext() before the early return,
eliminating the duplicated logic.

Best regards,
Henson

On Fri, Nov 07, 2025 at 10:00:15PM +0800, cca5507 wrote:

Attach a patch to do this.

There is no benefit in this change: the current code is fine.
--
Michael