pgsql: doc: Fix incorrect wording for --file in pg_dump

Started by Daniel Gustafsson2 months ago5 messages
#1Daniel Gustafsson
dgustafsson@postgresql.org

doc: Fix incorrect wording for --file in pg_dump

The documentation stated that the directory specified by --file
must not exist, but pg_dump does allow for empty directories to
be specified and used.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Bruce Momjian <bruce@momjian.us>
Discussion: /messages/by-id/534AA60D-CF6B-432F-9882-E9737B33D1B7@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f

Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

#2Erik Rijkers
er@xs4all.nl
In reply to: Daniel Gustafsson (#1)
Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

Op 11/7/25 om 15:27 schreef Daniel Gustafsson:

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f

Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Hi,

In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:

"unless the directory exist and is empty." should be
"unless the directory exists and is empty."

i.e., 'exists': because 'directory' is singular.

Thanks!

Erik

#3Chao Li
li.evan.chao@gmail.com
In reply to: Erik Rijkers (#2)
Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

On Nov 27, 2025, at 13:48, Erik Rijkers <er@xs4all.nl> wrote:

Op 11/7/25 om 15:27 schreef Daniel Gustafsson:

Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f
Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Hi,

In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:

"unless the directory exist and is empty." should be
"unless the directory exists and is empty."

i.e., 'exists': because 'directory' is singular.

+1, agreed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#4Michael Paquier
michael@paquier.xyz
In reply to: Erik Rijkers (#2)
Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

On Thu, Nov 27, 2025 at 06:48:56AM +0100, Erik Rijkers wrote:

In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:

"unless the directory exist and is empty." should be
"unless the directory exists and is empty."

i.e., 'exists': because 'directory' is singular.

Indeed, good catch. Daniel will very likely show up. If not, I'll go
apply a fix.
--
Michael

#5Daniel Gustafsson
dgustafsson@postgresql.org
In reply to: Michael Paquier (#4)
Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

On 27 Nov 2025, at 07:33, Michael Paquier <michael@paquier.xyz> wrote:

On Thu, Nov 27, 2025 at 06:48:56AM +0100, Erik Rijkers wrote:

In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:

"unless the directory exist and is empty." should be
"unless the directory exists and is empty."

i.e., 'exists': because 'directory' is singular.

Indeed, good catch. Daniel will very likely show up. If not, I'll go
apply a fix.

Done, sorry for the delay.

--
Daniel Gustafsson