Jan 2026

3 commits
Reword confusing comment to avoid "typo fixes"
14 Jan 2026Álvaro Herreramaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

The sole hunk rewrites the isMaxSpaceDisk comment in src/backend/utils/sort/tuplesort.c using Alvaro Herrera's inline wording #11, prompted by David Rowley's report #10. No indexed patchset contains this rewrite.

  • David Rowleysaw the final versiontrailerIdentified the ambiguous comment and proposed a rewrite #10, then explicitly accepted the final inline wording #13.
  • John Naylorsaw the final versiontrailerConfirmed that the previous wording remained unclear during the inline review #12 and received review credit in 4196d6178a.
Stop including {brin,gin}_tuple.h in tuplesort.h
12 Jan 2026Álvaro Herreramaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #51 of 1 reviewer saw the final version

Combines the tuplesort.h and relscan.h cleanup patches from #5, adding the catalog/indexing.h dependency reduction and associated include repairs. It omits the proposed attribute_stats.c include and the fourth patch's execReplication.c removals, despite the completion announcement #9; the commit credits sender Mario González as author.

  • Álvaro Herrerasaw the final versioncommittercommitted the patch
Move instrumentation-related structs to instrument_node.h
12 Jan 2026Álvaro Herreramaster19beta1REL_19_STABLE19beta1Also in: allow benign typedef redefinitions (C11) (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #51 of 1 reviewer saw the final version

Lands the instrumentation-move portion of #5, with comment and formatting cleanup, removal of the duplicate NUM_TUPLESORTMETHODS definition from src/include/utils/tuplesort.h, and the incidental tuplesort.c comment edit described in #6. I disagree with the source attribution in thread #52193: its October submission is an ancestor, while this thread's January patchset is the latest matching source; both the attachment and commit credit Alvaro Herrera and Mario González as co-authors.

  • Chao Lisaw the final versiontrailerQuestioned the access/executor layering and identified the SharedAggInfo naming error in #2, after which the instrumentation patch received only light corrections and editorial changes.

Credits across 3 commits

Author
Alvaro Herrera1
Mario González Troncoso1
Reviewer
Alvaro Herreracommitter1
Chao Li1
David Rowley1
John Naylor1
Co author
Alvaro Herrera1
Mario González Troncoso1
Committer
Alvaro Herrera3