Fix a minor typo in the comment of read_stream_start_pending
Hi hackers,
/*
* Sequential: Issue advice until the preadv() calls have caught
* up with the first advice issued for this sequential region, and
* then stay of the way of the kernel's own read-ahead.
*/
“out” is missing from the phrase “stay of the way” in this comment.
This patch fixes it.
Best,
Xuneng
Attachments:
v1-0001-Fix-a-minor-typo-in-the-comment-of-read_stream_st.patchapplication/octet-stream; name=v1-0001-Fix-a-minor-typo-in-the-comment-of-read_stream_st.patchDownload
From dc4f4faa7c812c74459e8dfea3ba8d738bbae43b Mon Sep 17 00:00:00 2001
From: alterego655 <824662526@qq.com>
Date: Mon, 10 Nov 2025 22:48:10 +0800
Subject: [PATCH v1] Fix a minor typo in the comment of
read_stream_start_pending
---
src/backend/storage/aio/read_stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/storage/aio/read_stream.c b/src/backend/storage/aio/read_stream.c
index 031fde9f4cb..f1b88d058e3 100644
--- a/src/backend/storage/aio/read_stream.c
+++ b/src/backend/storage/aio/read_stream.c
@@ -283,7 +283,7 @@ read_stream_start_pending_read(ReadStream *stream)
/*
* Sequential: Issue advice until the preadv() calls have caught
* up with the first advice issued for this sequential region, and
- * then stay of the way of the kernel's own read-ahead.
+ * then stay out of the way of the kernel's own read-ahead.
*/
if (stream->seq_until_processed != InvalidBlockNumber)
flags |= READ_BUFFERS_ISSUE_ADVICE;
--
2.51.0
On Nov 10, 2025, at 22:56, Xuneng Zhou <xunengzhou@gmail.com> wrote:
Hi hackers,
/*
* Sequential: Issue advice until the preadv() calls have caught
* up with the first advice issued for this sequential region, and
* then stay of the way of the kernel's own read-ahead.
*/“out” is missing from the phrase “stay of the way” in this comment.
This patch fixes it.Best,
Xuneng
<v1-0001-Fix-a-minor-typo-in-the-comment-of-read_stream_st.patch>
Looks good. Changing “stay of the way” to “stay out of the way” is correct English and improve readability.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On 11/11/2025 02:43, Chao Li wrote:
On Nov 10, 2025, at 22:56, Xuneng Zhou <xunengzhou@gmail.com> wrote:
/*
* Sequential: Issue advice until the preadv() calls have caught
* up with the first advice issued for this sequential region, and
* then stay of the way of the kernel's own read-ahead.
*/“out” is missing from the phrase “stay of the way” in this comment.
This patch fixes it.<v1-0001-Fix-a-minor-typo-in-the-comment-of-read_stream_st.patch>
Looks good. Changing “stay of the way” to “stay out of the way” is correct English and improve readability.
Fixed, thanks!
- Heikki
Hi,
On Wed, Dec 10, 2025 at 7:07 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
On 11/11/2025 02:43, Chao Li wrote:
On Nov 10, 2025, at 22:56, Xuneng Zhou <xunengzhou@gmail.com> wrote:
/*
* Sequential: Issue advice until the preadv() calls have caught
* up with the first advice issued for this sequential region, and
* then stay of the way of the kernel's own read-ahead.
*/“out” is missing from the phrase “stay of the way” in this comment.
This patch fixes it.<v1-0001-Fix-a-minor-typo-in-the-comment-of-read_stream_st.patch>
Looks good. Changing “stay of the way” to “stay out of the way” is correct English and improve readability.
Fixed, thanks!
- Heikki
Thanks!
--
Best,
Xuneng