AW: broken locale in 7.0.2 without multibyte support (F reeBSD 4.1-RELEASE) ?

Started by Zeugswetter Andreas SBabout 25 years ago2 messages
#1Zeugswetter Andreas SB
ZeugswetterA@wien.spardat.at

Today I inserted (unsigned char) casts into all the <ctype.h> function
calls I could find. This issue should be fixed as of current cvs.
Please try it again when you have time.

I am a sceptic to the many casts. Would'nt the clean solution be, to use
unsigned char througout the code ? The casts only help to avoid compiler
warnings or errors. They do not solve the underlying problem.

Andreas

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Zeugswetter Andreas SB (#1)
Re: AW: broken locale in 7.0.2 without multibyte support (F reeBSD 4.1-RELEASE) ?

Zeugswetter Andreas SB <ZeugswetterA@wien.spardat.at> writes:

Today I inserted (unsigned char) casts into all the <ctype.h> function
calls I could find. This issue should be fixed as of current cvs.
Please try it again when you have time.

I am a sceptic to the many casts. Would'nt the clean solution be, to use
unsigned char througout the code ?

No; see the prior discussion.

The casts only help to avoid compiler
warnings or errors. They do not solve the underlying problem.

You are mistaken.

regards, tom lane