Dec 2025

6 commits
Remove no longer needed casts from Pointer
4 Dec 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #171 of 1 reviewer saw the final version

The commit extracts eight unchanged cast-removal hunks from #17 in contrib/amcheck/verify_gin.c, contrib/pg_trgm/trgm_gin.c, src/backend/access/gin/ginentrypage.c, and src/backend/utils/adt/jsonb_gin.c. It leaves the Pointer declarations and other cleanup uncommitted and credits the patchset sender, Dagfinn Ilmari Mannsåker.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Remove no longer needed casts to Pointer
4 Dec 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The diff matches the fifth patch of #1, removing unnecessary casts to Pointer across 12 files, including src/backend/catalog/aclchk.c and src/include/fmgr.h.

  • Chao Lisaw the final versiontrailerChao reviewed the complete series, said it looked good, and reported a successful MacBook M4 build #2.
  • Bertrand Drouvotsaw the final versiontrailerBertrand checked the series for correctness and missed conversions and found it satisfactory #3.
Change Pointer to void *
3 Dec 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The src/include/c.h diff exactly matches the fourth patch of #1, changing Pointer from char * to void * and marking the typedef obsolescent.

  • Chao Lisaw the final versiontrailerChao explicitly assessed the typedef change and remaining GIN uses and reported a successful build #2.
  • Bertrand Drouvotsaw the final versiontrailerBertrand endorsed the separation of char * byte manipulation from void * generic pointers after checking the series #3.
Don't rely on pointer arithmetic with Pointer type
3 Dec 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #12 of 2 reviewers saw the final version

The commit matches the third patch of #1 except for removing redundant parentheses around the char * cast in GinDataLeafPageGetItems(), exactly as Bertrand requested #3.

  • Chao Lisaw the final versiontrailerChao checked the Pointer-to-char * substitutions and const qualification and reported that the series built successfully #2.
  • Bertrand Drouvotsaw the final versiontrailerBertrand reviewed the conversions and proposed the sole committed code adjustment, removing redundant cast parentheses #3.
Use more appropriate DatumGet* function
3 Dec 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

Both DatumGetPointer-to-DatumGetCString substitutions in src/test/modules/test_resowner/test_resowner_basic.c exactly match the second patch of #1.

  • Chao Lisaw the final versiontrailerChao explicitly reviewed the use of DatumGetCString for string formatting and approved the series #2.
  • Bertrand Drouvotsaw the final versiontrailerBertrand reported checking the complete series and finding its changes satisfactory #3.
Remove useless casts to Pointer
3 Dec 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The commit matches the first patch of #1, removing redundant memcpy/memmove argument casts in four files; the only difference is joining the memmove call onto one line in contrib/bloom/blvacuum.c.

  • Chao Lisaw the final versiontrailerChao explicitly checked that the memory-copy casts were redundant and reported a successful build #2.
  • Bertrand Drouvotsaw the final versiontrailerBertrand checked the complete series and searched for missed changes before endorsing it #3.

Credits across 6 commits

Author
Peter EisentrautLLM5
Dagfinn Ilmari Mannsåker1
Reviewer
Bertrand Drouvot5
Chao Li5
Peter Eisentrautcommitter1
Committer
Peter Eisentraut6

N LLM means N of the credits come from LLM analysis, not from commit trailers.