model-writtenrun 937 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Jakub Wartak proposed correcting two CPU macro typos in the 32-bit single-copy atomicity checks, while Daniel Gustafsson initially suggested removing checks that had been ineffective since 2017 #1 #2.
- John Naylor argued that 32-bit CI made the intended behavior relevant; testing by John, Zsolt Parragi, and Tom Lane showed that the predefined CPU macros depended on compiler flags and distribution defaults, and John demonstrated that the typo fix changed a 32-bit build’s generated output #3 #5 #6 #7 #9 #10 #11.
- Andres Freund redirected the solution toward removing the optimization because GCC did not reliably generate tear-free eight-byte operations from ordinary volatile accesses; he identified C11 atomics and lock-free capability checks as the reliable approach, but noted the newer MSVC requirements #12.
- Tomas Vondra raised backpatching, Andres expressed no preference, and Nathan Bossart endorsed removal and questioned the maintenance value of broader 32-bit-specific optimizations #13 #14 #15.
- Jakub marked the typo patch returned with feedback and proposed broader 32-bit deprecation, with Yura Sokolov suggesting extended support for a final 32-bit release; Daniel clarified the narrower atomicity scope, Nathan and Tom opposed dropping general support, and Andres emphasized retaining sanitizer coverage and distinguishing old CPU targets from 32-bit builds #16 #17 #18 #19 #20 #21 #22 #23.
- Daniel supplied a replacement patch removing both GCC and MSVC 32-bit atomicity conditions and proposed limiting the change to PostgreSQL 19 and later #24.
- Nathan explained that incorrect architecture detection already prevented MSVC from including this header and supported removing its 32-bit code; Daniel and Nathan agreed to apply the removal first and fix x86-64 detection separately #25 #26 #27 #28.
- Daniel committed the replacement patch unchanged as 801b9962e7 and confirmed completion in the final message; the thread records no completion of the separate MSVC x86-64 detection fix #24 #29.