Fix out-of-date comment on makeRangeConstructors

Started by Paul Jungwirth4 months ago3 messageshackers
Jump to latest
#1Paul Jungwirth
pj@illuminatedcomputing.com

Hi Hackers,

I noticed that makeRangeConstructors (in commands/typecmds.c) says:

We actually define 4 functions, with 0 through 3 arguments.

But that hasn't been true since 2011 (df73584431). We only have 2-arg
and 3-arg functions. Here is a quick patch to update the comment.

Yours,

--
Paul ~{:-)
pj@illuminatedcomputing.com

Attachments:

v1-0001-Fix-out-of-date-comment-on-makeRangeConstructors.patchtext/x-patch; charset=US-ASCII; name=v1-0001-Fix-out-of-date-comment-on-makeRangeConstructors.patchDownload+1-2
#2Chao Li
li.evan.chao@gmail.com
In reply to: Paul Jungwirth (#1)
Re: Fix out-of-date comment on makeRangeConstructors

On Dec 5, 2025, at 06:34, Paul A Jungwirth <pj@illuminatedcomputing.com> wrote:

Hi Hackers,

I noticed that makeRangeConstructors (in commands/typecmds.c) says:

We actually define 4 functions, with 0 through 3 arguments.

But that hasn't been true since 2011 (df73584431). We only have 2-arg
and 3-arg functions. Here is a quick patch to update the comment.

Yours,

--
Paul ~{:-)
pj@illuminatedcomputing.com
<v1-0001-Fix-out-of-date-comment-on-makeRangeConstructors.patch>

I think the fix is reasonable, which reflects to the current code:

```
static const char *const prosrc[2] = {"range_constructor2",
"range_constructor3"};
static const int pronargs[2] = {2, 3};
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Chao Li (#2)
Re: Fix out-of-date comment on makeRangeConstructors

On 05.12.25 03:26, Chao Li wrote:

On Dec 5, 2025, at 06:34, Paul A Jungwirth <pj@illuminatedcomputing.com> wrote:
I noticed that makeRangeConstructors (in commands/typecmds.c) says:

We actually define 4 functions, with 0 through 3 arguments.

But that hasn't been true since 2011 (df73584431). We only have 2-arg
and 3-arg functions. Here is a quick patch to update the comment.

I think the fix is reasonable, which reflects to the current code:

```
static const char *const prosrc[2] = {"range_constructor2",
"range_constructor3"};
static const int pronargs[2] = {2, 3};
```

committed