model-writtenrun 1392 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed replacing commented-out PG_GETARG_* declarations with pg_attribute_unused() declarations so compilers could check them and formatting would improve, while flagging hstore test failures, incorrect JSON declarations, and missing subtype documentation in #1.
- Heikki Linnakangas suggested #if 0 to preserve indentation without executing the declarations in #2, while David Geier and Chao Li warned that unused attributes would not prevent detoasting or other runtime effects in #3 and #4.
- Peter adopted preprocessor exclusion in #5, retaining unused arguments as useful API examples and splitting the deletion of four misleading jsonb_set_lax() declarations into a separate patch.
- Dean Rasheed recommended the established #ifdef NOT_USED convention in #6, and Tom Lane approved the revision with that style adjustment in #7.
- Ashutosh Bapat noted the convention's long history and expressed a preference for the more specific NOT_USED_ARGUMENTS name in #8, but the established name was retained.
- Peter committed the JSON cleanup from #5 unchanged as 846fb3c790 and committed the argument-declaration cleanup as a5b40d156e, changing the guards to #ifdef NOT_USED and removing redundant unused comments from the GiST documentation examples.
- Peter confirmed completion in #9, leaving both patches committed and no attached patch outstanding.