Change comment in `contrib/amcheck` regression suite.

Started by Kirill Reshke12 months ago4 messageshackers
Jump to latest
#1Kirill Reshke
reshkekirill@gmail.com

I did find a misleading comment in amcheck's regression test suite,
during un-related hacking in Cloudberry[0]https://github.com/apache/cloudberry -- Best regards, Kirill Reshke. There is a comment which
says `-- Check that sequences are rejected` but those are supported
starting c3b011d

Lets make things not misleading.

[0]: https://github.com/apache/cloudberry -- Best regards, Kirill Reshke
--
Best regards,
Kirill Reshke

Attachments:

v1-0001-Change-comment-in-contrib-amcheck-regression-suit.patchapplication/octet-stream; name=v1-0001-Change-comment-in-contrib-amcheck-regression-suit.patchDownload+2-1
#2Andreas Karlsson
andreas.karlsson@percona.com
In reply to: Kirill Reshke (#1)
Re: Change comment in `contrib/amcheck` regression suite.

On 12/6/25 12:53 PM, Kirill Reshke wrote:

I did find a misleading comment in amcheck's regression test suite,
during un-related hacking in Cloudberry[0]. There is a comment which
says `-- Check that sequences are rejected` but those are supported
starting c3b011d

Lets make things not misleading.

I think we should change a bit more to make it more like the tests for
heap tables. What do you think?

Andreas

Attachments:

0001-Improve-amcheck-heap-tests-for-sequences.patchtext/x-patch; charset=UTF-8; name=0001-Improve-amcheck-heap-tests-for-sequences.patchDownload+33-7
#3Kirill Reshke
reshkekirill@gmail.com
In reply to: Andreas Karlsson (#2)
Re: Change comment in `contrib/amcheck` regression suite.

On Wed, 14 Jan 2026 at 11:06, Andreas Karlsson <andreas@proxel.se> wrote:

On 12/6/25 12:53 PM, Kirill Reshke wrote:

I did find a misleading comment in amcheck's regression test suite,
during un-related hacking in Cloudberry[0]. There is a comment which
says `-- Check that sequences are rejected` but those are supported
starting c3b011d

Lets make things not misleading.

I think we should change a bit more to make it more like the tests for
heap tables. What do you think?

Andreas

Well, additional tests are good, but I did not get why cleanup is
needed (how it worked before?). We don't create anything new in your
patch, but for some reason need to drop..

--
Best regards,
Kirill Reshke

#4Andreas Karlsson
andreas.karlsson@percona.com
In reply to: Kirill Reshke (#3)
Re: Change comment in `contrib/amcheck` regression suite.

On 1/14/26 9:53 AM, Kirill Reshke wrote:

Well, additional tests are good, but I did not get why cleanup is
needed (how it worked before?). We don't create anything new in your
patch, but for some reason need to drop..

Just another issue I spotted. Sorry, I should have split it into two
patches for ease for review.

Andreas

Attachments:

t52824_4
v3-0001-Drop-all-object-created-by-amchecks-heap-tests.patchtext/x-patch; charset=UTF-8; name=v3-0001-Drop-all-object-created-by-amchecks-heap-tests.patchDownload+9-1
v3-0002-Improve-amcheck-heap-tests-for-sequences.patchtext/x-patch; charset=UTF-8; name=v3-0002-Improve-amcheck-heap-tests-for-sequences.patchDownload+24-7