Change comment in `contrib/amcheck` regression suite.
Started by Kirill Reshkeabout 1 month ago1 messages
I did find a misleading comment in amcheck's regression test suite,
during un-related hacking in Cloudberry[0]https://github.com/apache/cloudberry -- Best regards, Kirill Reshke. There is a comment which
says `-- Check that sequences are rejected` but those are supported
starting c3b011d
Lets make things not misleading.
[0]: https://github.com/apache/cloudberry -- Best regards, Kirill Reshke
--
Best regards,
Kirill Reshke
Attachments:
v1-0001-Change-comment-in-contrib-amcheck-regression-suit.patchapplication/octet-stream; name=v1-0001-Change-comment-in-contrib-amcheck-regression-suit.patchDownload
From 369f7f4e695afecbb6dcf24c59f90539da628da7 Mon Sep 17 00:00:00 2001
From: reshke <reshke@double.cloud>
Date: Sat, 6 Dec 2025 11:45:35 +0000
Subject: [PATCH v1] Change comment in `contrib/amcheck` regression suite.
Found during un-related hacking. Lets make things not misleading.
---
contrib/amcheck/expected/check_heap.out | 2 +-
contrib/amcheck/sql/check_heap.sql | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/amcheck/expected/check_heap.out b/contrib/amcheck/expected/check_heap.out
index 979e5e84e72..e5b370f1e44 100644
--- a/contrib/amcheck/expected/check_heap.out
+++ b/contrib/amcheck/expected/check_heap.out
@@ -213,7 +213,7 @@ SELECT * FROM verify_heapam('test_view',
endblock := NULL);
ERROR: cannot check relation "test_view"
DETAIL: This operation is not supported for views.
--- Check that sequences are rejected
+-- Check that sequences are supported
CREATE SEQUENCE test_sequence;
SELECT * FROM verify_heapam('test_sequence',
startblock := NULL,
diff --git a/contrib/amcheck/sql/check_heap.sql b/contrib/amcheck/sql/check_heap.sql
index 1745bae634e..58828a32e96 100644
--- a/contrib/amcheck/sql/check_heap.sql
+++ b/contrib/amcheck/sql/check_heap.sql
@@ -124,7 +124,7 @@ SELECT * FROM verify_heapam('test_view',
startblock := NULL,
endblock := NULL);
--- Check that sequences are rejected
+-- Check that sequences are supported
CREATE SEQUENCE test_sequence;
SELECT * FROM verify_heapam('test_sequence',
startblock := NULL,
--
2.43.0