add some errhint for regexp* functions.
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t52848psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 20, 2026 at 02:16 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t52848_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t52848_1 && git checkout t52848_1Patchset v1 (message #1) is on t52848_1
hi.
Some of the regexp* function error messages seem not very helpful, I think.
like:
ereport(ERROR,
errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("invalid value for parameter \"%s\": %d",
"start", start));
so I added a errhint, errhint would be better than refactoring existing errmsg.
for the above example, I've add:
+ errhint("\"%s\" must be an integer value greater than zero", "start")));
jian he <jian.universality@gmail.com> writes:
Some of the regexp* function error messages seem not very helpful, I think.
like:
ereport(ERROR,
errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("invalid value for parameter \"%s\": %d",
"start", start));
so I added a errhint, errhint would be better than refactoring existing errmsg.
for the above example, I've add:
+ errhint("\"%s\" must be an integer value greater than zero", "start")));
There are probably hundreds of other places where the ereport
doesn't provide such detail, and I don't see that this adds
much. If you don't understand why a negative value isn't OK,
you still need to go RTFM.
(This message doesn't follow our style guidelines, either.)
regards, tom lane