model-writtenrun 6947 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Jacob Champion proposed replacing libpq-oauth's private interfaces with a stable public ABI and exploring alternative OAuth flows in #1, using a versioned request structure because a running application can load a newer plugin after an upgrade.
- Chao Li reviewed the preparatory and ABI patches in #2, explicitly leaving the experimental plugin patch unreviewed; Jacob incorporated documentation and comment corrections in #3.
- The three preparatory patches from #3 landed unchanged on December 17 as 8b217c96ea, 781ca72139, and ab8af1db43, fixing socket-macro naming, Meson compiler arguments, and logging-test races respectively, with backports to PostgreSQL 18.
- Zsolt Parragi successfully tested external client and server plugins in #4, but questioned misleading loader errors, issuer validation, configuration, direct token passing, and whether the interface should support generic authentication.
- Jacob retained client-side issuer validation to protect against malicious servers and kept this work specific to OAuth in #5, #7, and #9, while treating generic SASL plugins and per-connection configuration as separate future work.
- After a gap, #10 resumed the remaining series with hook-owned error strings instead of PQExpBuffer, retained the subclass-style V2 request, introduced PQgetThreadLock(), and exposed ineffective cleanup diagnostics that needed to become stderr warnings.
- Zsolt's review in #11 found an allocation leak, an incomplete feature macro, an unused cleanup argument, and unsafe environment-string mutation; Jacob addressed these in #13 and explained in #12 that a global PGOAUTHMODULE selector would not ship in PostgreSQL 19 because it lacked a satisfactory path toward per-connection configuration.
- Jacob added v1 misuse tests and experimental request poisoning in #14, combining pointer masking with Valgrind and AddressSanitizer to detect hooks that access V2 fields through the v1 API.
- Jacob also incorporated the standalone thread-lock submission from thread #53426 into #14, making this March 3 series the latest matching patchset despite the other thread's attribution to its February 27 submission #616623.
- The cleanup-warning and thread-lock patches from #14 landed unchanged as f8c0b91a60 and b8d7685835; #15 resent the remainder and removed the uncertain AddressSanitizer integration.
- The V2 request API from #15 landed as e982331b52 with documentation improvements, a corrected comment, and a test distinguishing the derived issuer identifier from the connection option, as reported in #17.
- Zsolt identified misleading suggestions to install an already-present library in #16; Jacob corrected failure handling in #19 and extracted optional libpq_oauth_init support so developers could experiment with replacement libraries through the runtime linker.
- Zsolt approved the four intended landing patches in #20 and verified the pointer-mask casts in #22, while Jacob identified unused Valgrind-only variables that needed conditional compilation in #21.
- The API migration from #19 landed as 6225403f27 with obsolete typedef-list entries removed, and its encoding-isolation companion landed unchanged as dba3560448, establishing the unversioned libpq-oauth module.
- Jonathan Gonzalez V. supplied an inline fix for a missing experimental-plugin test dependency in #23; Jacob incorporated it in the remaining series at #24, which also guarded Valgrind-only variables and reported a separate Makefile correction prompted by the indri buildfarm member.
- Chao requested an assertion that the error pointer was initially unset in #25, and Zsolt requested the correct polling-status type for the asynchronous wrapper in #26.
- The poisoning patch from #24 landed with both review corrections as 0af4d402cb, while optional initializer support landed unchanged as 09532b4040; Jacob confirmed the corrections in #27 and #28.
- At the thread's end, the ABI stabilization and developer-facing replacement support had landed, while the user-facing plugin selector and its experimental tests remained deferred; Jacob also deferred renaming use_builtin_flow() until a future plugin refactor in #27.