[PATCH v1] Fixed a spelling error in the comments in gininsert.c
Hi hackers,
This patch fixs a typo in gin code comments, detial as follows:
diff --git a/src/backend/access/gin/gininsert.c b/src/backend/access/gin/gininsert.c
index df30dcc..8824607 100644
--- a/src/backend/access/gin/gininsert.c
+++ b/src/backend/access/gin/gininsert.c
@@ -1784,7 +1784,7 @@ _gin_parallel_merge(GinBuildState *state)
++numtuples);
}- /* relase all the memory */
+ /* release all the memory */
GinBufferFree(buffer); tuplesort_end(state->bs_sortstate);
@@ -1972,7 +1972,7 @@ _gin_process_worker_data(GinBuildState *state, Tuplesortstate *worker_sort,
GinBufferReset(buffer);
}
- /* relase all the memory */
+ /* release all the memory */
GinBufferFree(buffer);--
Best regards,
Xingbin SHE
Email: xingbin.she@qq.com
Attachments:
v1-0001-Fixed-a-spelling-error-in-the-comments-in-gininse.patchapplication/octet-stream; charset=utf-8; name=v1-0001-Fixed-a-spelling-error-in-the-comments-in-gininse.patchDownload
From a2f8161c07bf836e02f2b8f6e5c2ebf732de472f Mon Sep 17 00:00:00 2001
From: Xingbin She <xingbin.she@qq.com>
Date: Fri, 19 Dec 2025 10:40:02 +0800
Subject: [PATCH v1] Fixed a spelling error in the comments in gininsert.c.
Author: Xingbin She <xingbin.she@qq.com>
---
src/backend/access/gin/gininsert.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/access/gin/gininsert.c b/src/backend/access/gin/gininsert.c
index df30dcc..8824607 100644
--- a/src/backend/access/gin/gininsert.c
+++ b/src/backend/access/gin/gininsert.c
@@ -1784,7 +1784,7 @@ _gin_parallel_merge(GinBuildState *state)
++numtuples);
}
- /* relase all the memory */
+ /* release all the memory */
GinBufferFree(buffer);
tuplesort_end(state->bs_sortstate);
@@ -1972,7 +1972,7 @@ _gin_process_worker_data(GinBuildState *state, Tuplesortstate *worker_sort,
GinBufferReset(buffer);
}
- /* relase all the memory */
+ /* release all the memory */
GinBufferFree(buffer);
tuplesort_end(worker_sort);
--
1.8.3.1
On Fri, Dec 19, 2025 at 10:47:22AM +0800, Xingbin She wrote:
This patch fixs a typo in gin code comments, detial as follows:
Yep, will fix. Thanks for the report!
--
Michael
Hi Michael,
Michael Paquier <michael@paquier.xyz> 于2025年12月19日周五 10:53写道：
On Fri, Dec 19, 2025 at 10:47:22AM +0800, Xingbin She wrote:
This patch fixs a typo in gin code comments, detial as follows:
Yep, will fix. Thanks for the report!
--
Michael
I just found another typo in gininsert.c(maybe on a new thread)
Comments for _gin_build_tuple():
"
* For by-reference data types, we store the actual data. For by-val types
* we simply copy the whole Datum, so that we don't have to care about stuff
* like endianess etc.
"
"endianess" should be "endianness".
--
Thanks,
Tender Wang
On Fri, Dec 19, 2025 at 01:55:14PM +0800, Tender Wang wrote:
I just found another typo in gininsert.c(maybe on a new thread)
Comments for _gin_build_tuple():"
* For by-reference data types, we store the actual data. For by-val types
* we simply copy the whole Datum, so that we don't have to care about stuff
* like endianess etc.
""endianess" should be "endianness".
Indeed. Thanks.
--
Michael
On Dec 20, 2025, at 08:24, Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Dec 19, 2025 at 01:55:14PM +0800, Tender Wang wrote:
I just found another typo in gininsert.c(maybe on a new thread)
Comments for _gin_build_tuple():"
* For by-reference data types, we store the actual data. For by-val types
* we simply copy the whole Datum, so that we don't have to care about stuff
* like endianess etc.
""endianess" should be "endianness".
Indeed. Thanks.
--
Michael
I found that earlier, but when I checked with https://www.onelook.com/?w=endianess, it has two matches, so I guessed that spelling is acceptable.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On Sat, Dec 20, 2025 at 08:31:28AM +0800, Chao Li wrote:
I found that earlier, but when I checked with
https://www.onelook.com/?w=endianess, it has two matches, so I
guessed that spelling is acceptable.
I've always heard only about the spelling with two 'n', the one you
are pointing at being a redirection to the two-n version as well.
Additionally, the rest of the tree seems to agree with that:
$ git grep endianness | wc -l
13
$ git grep endianess | wc -l
0
--
Michael
On Dec 22, 2025, at 06:22, Michael Paquier <michael@paquier.xyz> wrote:
On Sat, Dec 20, 2025 at 08:31:28AM +0800, Chao Li wrote:
I found that earlier, but when I checked with
https://www.onelook.com/?w=endianess, it has two matches, so I
guessed that spelling is acceptable.I've always heard only about the spelling with two 'n', the one you
are pointing at being a redirection to the two-n version as well.
Additionally, the rest of the tree seems to agree with that:
$ git grep endianness | wc -l
13
$ git grep endianess | wc -l
0
--
Michael
I have no objection at all.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/