[PATCH v1] replindex: Fix comment grammar in build_replindex_scan_key()
Hi all,
This is a trivial grammar fix for the comment of build_replindex_scan_key() function in replindex.c.
Two missing indefinite articles 'a' are added to make the comment grammatically correct.
No functional changes are involved.
Patch is attached below.
Thanks,
zourenli
<398740848@qq.com>
Attachments:
v1-0001-corrects-minor-grammatical-issues-in-comment-of-b.patchapplication/octet-stream; charset=utf-8; name=v1-0001-corrects-minor-grammatical-issues-in-comment-of-b.patchDownload
From 44695d848cf6a0f2c63ac69c73c0eba4cd9a8654 Mon Sep 17 00:00:00 2001
From: zourenli <398740848@qq.com>
Date: Mon, 29 Dec 2025 16:11:45 +0800
Subject: [PATCH v1] corrects minor grammatical issues in comment of
build_replindex_scan_key()
The changes are:
* \"This is not generic routine\" -> \"This is not a generic routine\"
* \"used for REPLICA IDENTITY FULL table\" -> \"used for a REPLICA IDENTITY FULL table\"
Author: zourenli <398740848@qq.com>"
---
src/backend/executor/execReplication.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/executor/execReplication.c b/src/backend/executor/execReplication.c
index 860f79f9cc1..c0b1dcb23c2 100644
--- a/src/backend/executor/execReplication.c
+++ b/src/backend/executor/execReplication.c
@@ -46,8 +46,8 @@ static bool tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2,
*
* Returns how many columns to use for the index scan.
*
- * This is not generic routine, idxrel must be PK, RI, or an index that can be
- * used for REPLICA IDENTITY FULL table. See FindUsableIndexForReplicaIdentityFull()
+ * This is not a generic routine, idxrel must be PK, RI, or an index that can be
+ * used for a REPLICA IDENTITY FULL table. See FindUsableIndexForReplicaIdentityFull()
* for details.
*
* By definition, replication identity of a rel meets all limitations associated
--
2.32.0
On Dec 29, 2025, at 16:20, zourenli <398740848@qq.com> wrote:
Hi all,
This is a trivial grammar fix for the comment of build_replindex_scan_key() function in replindex.c.
Two missing indefinite articles 'a' are added to make the comment grammatically correct.
No functional changes are involved.Patch is attached below.
Thanks,
zourenli
<398740848@qq.com><v1-0001-corrects-minor-grammatical-issues-in-comment-of-b.patch>
Both fixes look unambiguously correct to me:
• “This is not generic routine” -> “This is not a generic routine”
• “used for REPLICA IDENTITY FULL table” -> “used for a REPLICA IDENTITY FULL table”
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On Tue, Dec 30, 2025 at 4:04 AM Chao Li <li.evan.chao@gmail.com> wrote:
On Dec 29, 2025, at 16:20, zourenli <398740848@qq.com> wrote:
<v1-0001-corrects-minor-grammatical-issues-in-comment-of-b.patch>
Both fixes look unambiguously correct to me:
• “This is not generic routine” -> “This is not a generic routine”
• “used for REPLICA IDENTITY FULL table” -> “used for a REPLICA IDENTITY FULL table”
LGTM.
--
With Regards,
Amit Kapila.