Fix typo in code comment
Hi hickers,
I fixed a comment error in the `WaitForParallelWorkersToFinish` function. The original comment was "In that case, or latch should have been set as well...", where I think "or" is a typo and it should be "our".
--
Best regards,
Ke Lan
Email:ke_lan1@qq.com
Attachments:
v1-0001-correct-typos-in-the-code-comments.patchapplication/octet-stream; charset=utf-8; name=v1-0001-correct-typos-in-the-code-comments.patchDownload
From c366532dac7136ea76cdb601257ad54db92dd78a Mon Sep 17 00:00:00 2001
From: kelan <ke_lan1@qq.com>
Date: Tue, 30 Dec 2025 15:22:55 +0800
Subject: [PATCH v1] correct typos in the code comments.
Author: Ke Lan <ke_lan1@qq.com>
---
src/backend/access/transam/parallel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/access/transam/parallel.c b/src/backend/access/transam/parallel.c
index 642c61f..d37431a 100644
--- a/src/backend/access/transam/parallel.c
+++ b/src/backend/access/transam/parallel.c
@@ -884,7 +884,7 @@ WaitForParallelWorkersToFinish(ParallelContext *pcxt)
* the worker writes messages and terminates after the
* CHECK_FOR_INTERRUPTS() near the top of this function and
* before the call to GetBackgroundWorkerPid(). In that case,
- * or latch should have been set as well and the right things
+ * our latch should have been set as well and the right things
* will happen on the next pass through the loop.
*/
}
--
1.8.3.1
On Dec 31, 2025, at 09:10, kelan <ke_lan1@qq.com> wrote:
Hi hickers,
I fixed a comment error in the `WaitForParallelWorkersToFinish` function. The original comment was "In that case, or latch should have been set as well...", where I think "or" is a typo and it should be "our".--
Best regards,
Ke Lan
Email:ke_lan1@qq.com<v1-0001-correct-typos-in-the-code-comments.patch>
Looking at the context, “or” doesn’t make sense here. Both “the” and “our” would work grammatically, and given the intent of the comment, “our” seems the most likely original wording.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On Sun, Jan 4, 2026 at 1:24 AM Chao Li <li.evan.chao@gmail.com> wrote:
On Dec 31, 2025, at 09:10, kelan <ke_lan1@qq.com> wrote:
Hi hickers,
I fixed a comment error in the `WaitForParallelWorkersToFinish` function. The original comment was "In that case, or latch should have been set as well...", where I think "or" is a typo and it should be "our".--
Best regards,
Ke Lan
Email:ke_lan1@qq.com<v1-0001-correct-typos-in-the-code-comments.patch>
Looking at the context, “or” doesn’t make sense here. Both “the” and “our” would work grammatically, and given the intent of the comment, “our” seems the most likely original wording.
I agree that it's a typo. I've just pushed the patch. Thank you!
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com