model-writtenrun 1394 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed restoring const qualifiers in necessary casts across 40 files, limiting the cleanup to straightforward cases found with gcc -Wcast-qual rather than resolving every warning #1.
- Chao Li initially approved the patch as const-correctness cleanup without semantic changes #2.
- Bertrand Drouvot reported that the VARDATA macro changes introduced discarded-qualifier warnings, checked pointer-to-pointer qualifier placement, and supplied additional fixes found with Coccinelle #3.
- Peter accepted the additional fixes, explaining that conditional compilation and separately run Unicode tests had hidden those cases from his testing, while asking how to reproduce the macro warnings #4.
- Bertrand supplied compiler details and CI confirmation #5 #6, and Chao independently reproduced the warnings with an ordinary make invocation, correcting his initial review #7.
- Peter committed 5ca5f12c2c from #1, omitting four problematic VARDATA macro changes and adding Bertrand's SP-GiST and Unicode-test fixes; his final message confirmed the corrections had landed, with no further revision pending in the thread #8.