Feb 2026

6 commits
Fix additional fallthrough warnings from clang
23 Feb 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

All eight files retain the submitted changes modulo rebase, including the unconditional break in logical/decode.c and pg_fallthrough in xlogrecovery.c #1.

  • Jelte Fennema-Niosaw the final versiontrailerJelte said the whole submission looked okay #2, and these warning fixes landed without substantive changes.
Enable -Wimplicit-fallthrough option for clang
23 Feb 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 1 reviewer saw the final version

The configure and Meson warning-option changes match the submitted patch except for an added break in meson.build's C++ flag-selection loop #1. This prevents selecting both supported flags and weakening GCC's attribute requirement.

  • Jelte Fennema-Niosaw an earlier versiontrailerJelte approved the submitted series #2, before the committed C++ flag-selection loop gained its corrective break.
test_cplusplusext: Add C++ pg_fallthrough test case
23 Feb 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The switch exercising pg_fallthrough in src/test/modules/test_cplusplusext/test_cplusplusext.cpp is absent from the attached series #1; Peter explicitly reported adding the C++ test when committing #4.

Fix additional fallthrough warning
23 Feb 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The commit exactly matches the submitted reindexdb.c change, replacing the fallthrough comment after Assert(user_list != NULL) with pg_fallthrough #1.

  • Jelte Fennema-Niosaw the final versiontrailerJelte said the whole submission looked okay #2, and this patch landed unchanged.
Use fallthrough attribute instead of comment
19 Feb 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 1 reviewer saw the final version

The submitted conversion is preserved, but src/include/c.h replaces the __cpp_attributes condition with a __cplusplus >= 201703L check, following the discussion #2 #3. Four missing postgres.c conversions are explained by removal of those fallthrough sites in the intervening base changes.

  • Jelte Fennema-Niosaw an earlier versiontrailerJelte reviewed the series and suggested using __cplusplus #2, but no subsequent review covers the committed C++17 threshold that changes attribute selection.
Remove useless fallthrough annotation
19 Feb 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The single deletion in src/backend/postmaster/postmaster.c exactly matches the submitted removal of the fallthrough comment after the last switch case #1.

  • Jelte Fennema-Niosaw the final versiontrailerJelte said the whole submission looked okay #2, and this cleanup landed unchanged.

Credits across 6 commits

Author
Peter EisentrautLLM5
Reviewer
Jelte Fennema-Nio5
Committer
Peter Eisentraut6

N LLM means N of the credits come from LLM analysis, not from commit trailers.