model-writtenrun 1389 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed replacing fallthrough comments with a portable pg_fallthrough attribute macro, requiring GCC's -Wimplicit-fallthrough=5 and Clang's -Wimplicit-fallthrough, and fixing additional warnings exposed by Clang in a five-patch submission #1.
- Jelte Fennema-Nio reviewed the series positively and questioned using __cpp_attributes instead of __cplusplus; Peter agreed to change the condition #2 #3.
- On February 19, Peter committed the final-case annotation cleanup unchanged as 0c3fbb3fef and the attribute conversion as 8354b9d6b6, with a C++17 threshold for the standard attribute and rebase adjustments for removed fallthrough sites from #1.
- On February 23, the additional Clang warning fixes from #1 landed unchanged modulo rebase as 3a63b76571 and 3f7a0e1e55, while warning enablement landed as 0284e07599 with a corrective break in Meson's C++ flag-selection loop.
- Peter also added a C++ pg_fallthrough test without posting an attached patch, committed it as 2f2c9d8363, and announced that the series and additional test were committed #4.
- In April, Tom Lane reported that buildfarm member ayu produced an unannotated-fallthrough warning in the new test with Clang 4.0, questioning whether such an old compiler warranted accommodation #5.
- Peter investigated a clang::fallthrough fallback for Clang 6 through 9, but reported syntax errors with Clang 5 and older and observed that the warning option appeared ineffective in C mode before Clang 10 #6.
- Tom concluded that adding the fallback could make matters worse and recommended leaving the implementation alone; the series remained fully committed, with no old-Clang workaround adopted in the thread #7.