Mar 2026

3 commits
Refactor some code around ALTER TABLE [NO] INHERIT
17 Mar 2026Michael Paquiermaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #191 of 2 reviewers saw the final version

Commits the inheritance-refactoring component of #19, with identical regression changes but without its six execution-phase assertions. In src/backend/commands/tablecmds.c, Michael also rewrites the preparation comment and moves the column/constraint description to CreateInheritance(), as explained in #20.

  • Michael Paquiersaw the final versiontrailerMichael identified missing typed-table coverage and requested an assertion in #18, then reviewed and committed the remainder with assertion and comment adjustments described in #20.
  • Zsolt Parragisaw an earlier versiontrailerZsolt requested tests and cleanup in #5, corrected a test annotation in #8, and demonstrated the redundant execution check in #12, before its removal and later assertion revisions.
Add regression test for ALTER TABLE .. NO INHERIT on typed tables
17 Mar 2026Michael Paquiermaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #191 of 1 reviewer saw the final version

Extracts the standalone typed-table regression-test component of #19; its diffs in src/test/regress/sql/typed_table.sql and src/test/regress/expected/typed_table.out are identical to the attachment. Michael proposed this test in #18, but is excluded from suggested reviewers because he committed it.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Reject ALTER TABLE .. CLUSTER earlier for partitioned tables
16 Mar 2026Michael Paquiermaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #151 of 2 reviewers saw the final version

Commits only the CLUSTER component of #15, leaving the inheritance component pending. Beyond rebasing, the sole diff change is deletion of the explanatory comment above the new assertion in src/backend/commands/cluster.c.

  • Michael Paquiersaw the final versiontrailerMichael requested analysis of the remaining mark_index_clustered() callers in #10, then confirmed the call-path reasoning and announced the commit in #16.
  • Zsolt Parragisaw an earlier versiontrailerZsolt questioned the remaining error path in #5 and analyzed VACUUM FULL and CLUSTER callers in #8 and #11, before the runtime check was replaced by an assertion.

Credits across 3 commits

Author
Chao Li3
Reviewer
Michael Paquiercommitter3
Zsolt Parragi2
Committer
Michael Paquier3