model-writtenrun 1174 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Zsolt Parragi proposed suppressing misleading OAuth discovery authentication failures by introducing a SASL restart status mapped to STATUS_EOF, initially replacing the FATAL entry with a LOG message #1.
- Daniel Gustafsson questioned whether discovery warranted production logging #2, and Zsolt lowered the message to DEBUG1 #3.
- Jacob Champion recommended naming the status ABANDONED because the server cannot know whether the client will retry, representing discovery as an OAuth state, bypassing token validation, and avoiding an unauthenticated username in the message #4; Zsolt incorporated those changes #5.
- Chao Li identified stale commit wording and suggested consolidating state assignments #6; Zsolt corrected the wording but explained that moving the assignment would overwrite the state being tested #8, then incorporated Andrey Borodin's SASL API documentation suggestions #9 into #11.
- Jacob reported an intermittent test failure #12, and Zsolt traced it to discovery and login backends logging concurrently #13; they deferred broader test synchronization work and removed the unreliable positive log expectations while retaining checks against FATAL messages #14 #15.
- During pre-commit review, Jacob discovered that STATUS_EOF also suppressed the final ErrorResponse required to finish the SASL exchange; his diagnostic libpq patch exposed the problem by waiting for that response, and he proposed FATAL_CLIENT_ONLY instead #16.
- Zsolt implemented FATAL_CLIENT_ONLY and invoked it directly from the OAuth mechanism #17; Andrey reviewed the new severity and accepted retaining fatal-session accounting and the existing client-only logging conventions #18 #20.
- Jacob objected that terminating inside the mechanism bypassed ClientAuthentication_hook #21, then supplied a three-patch series combining FATAL_CLIENT_ONLY, an abandoned-exchange flag propagated through the normal authentication flow, and the OAuth logging change #23.
- Chao reviewed the final series and approved the OAuth patch while questioning unreachable logging cases and the production error check #24; Jacob retained those choices for consistency and enforcement of the security-sensitive API boundary #27 #28.
- Zsolt proposed making the interface more generic and welcomed a possible STATUS_SILENT_ERROR alternative, but accepted the existing series #25 #29; Jacob deferred broader API refactoring and allowed additional review time #30.
- The FATAL_CLIENT_ONLY prerequisite from #23 landed unchanged as c2bca7cc96, with the commit explaining the independent implementations by Jacob and Zsolt and crediting Andrey's review.
- The remaining two patches from #23 landed as c4ff16339f and e020a897ef, preserving the submitted SASL implementation and OAuth changes apart from rebased test context.
- Jacob confirmed that the series was pushed and invited post-commit review #31; the diagnostic libpq patch and broader logging-test synchronization work were left outside the committed series.