Feb 2026

2 commits
Convert SpinLock* macros to static inline functions.
23 Feb 2026Nathan Bossartmaster19beta1REL_19_STABLE19beta1Also in: Atomic operations within spinlocks (not this thread)
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #12 of 2 reviewers saw the final version

The commit takes the third patch of #1, converting the three wrappers in src/include/storage/spin.h to inline functions, but retains volatile in their signatures and documentation. The separate volatile-cleanup patch was abandoned, as Nathan confirmed in #7.

  • Fabrízio de Royes Mellosaw the final versiontrailerAfter checking his PG_TRY/PG_CATCH concern, he approved the series in #4; the committed wrapper conversion differs only by retaining volatile qualifiers.
  • Andres Freundsaw the final versiontrailerHe reviewed the conversion and recommended retaining the documented volatile parameter in #5, which Nathan adopted in the committed signatures.
Remove SpinLockFree() and S_LOCK_FREE().
19 Feb 2026Nathan Bossartmaster19beta1REL_19_STABLE19beta1Also in: Remove SpinLockFree() / S_LOCK_FREE()?
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #12 of 2 reviewers saw the final version

The commit takes the second patch of the three-patch series in #1 unchanged apart from base metadata: all 38 deletions match across src/backend/storage/lmgr/s_lock.c, src/include/storage/s_lock.h, and src/include/storage/spin.h. It does not include the series' volatile cleanup or inline conversion.

  • Fabrízio de Royes Mellosaw the final versiontrailerHe explicitly supported removing the unused interface in #2 and approved the patches after further inspection in #4.
  • Andres Freundsaw the final versiontrailerHe supported the removal in #5, and that portion of the series landed unchanged.

Credits across 2 commits

Author
Nathan BossartLLM2
Reviewer
Andres Freund2
Fabrízio de Royes Mello2
Committer
Nathan Bossart2

N LLM means N of the credits come from LLM analysis, not from commit trailers.