model-writtenrun 6955 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Bertrand Drouvot proposed a one-line correction to define pg_icu_unicode_version with an explicit void parameter list, following PostgreSQL's existing convention #1.
- Chao Li reviewed the patch and asked about consistently enforcing and documenting the convention; Bertrand favored enabling -Wstrict-prototypes by default, while Joe Conway suggested the committing checklist as a documentation location #2 #3 #4.
- Peter Eisentraut proposed enabling both -Wstrict-prototypes and -Wold-style-definition to avoid repeated manual corrections, and Andreas Karlsson supported enabling the warnings unless there was a good reason against it #5 #6.
- Jeff Davis committed the attached correction unchanged as 11171fe1fc and announced its completion #7.
- After Bertrand volunteered to add the warnings, Peter reported that configure's generated main() definitions made early activation break probes and suggested adding the flags at the end without capability tests because supported GCC and Clang versions already provided them #8 #9.
- Bertrand confirmed the configure failures, including interference with PGAC_PRINTF_ARCHETYPE and MinGW CI, and reported moving the flags late enough to avoid them; the thread ended with the original fix landed and the warning-enablement patch posted in a separate thread #10.
- Peter subsequently committed Bertrand's preparatory ECPG and libpq test-definition cleanup as d7ad79e506, deriving from this discussion without a matching attachment here.
- Peter enabled both warnings in the build systems and suppressed readline-header warnings as 29bf4ee749; the implementation is attributed to thread #52804 and its source patch #608134, while this thread supplied the configure-placement findings #9 #10.