model-writtenrun 1139 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Robert Haas proposed an optional nonthrowing OOM path for dshash insertion, hoping to include it in PostgreSQL 19 for pg_stash_advice, with an extensible flags argument and a compatibility macro for existing callers #1.
- Chao Li supported the design and requested consistent assertion placement and removal of a nested block #2; Sami Imseih agreed, reported successful OOM and recovery tests, and supplied a separate test_dshash module #3.
- Robert incorporated the implementation nits in #4, which Sami approved in #5; Robert also explained that OOM behavior should be selected per call and reviewed the test module, requesting stronger value checks, additional coverage, a constant memory limit, and bounded loops #6.
- After Chao approved the revised implementation #7, Robert committed #4 unchanged as 6f0738ddec and announced completion of the API change #8.
- Sami expanded and hardened the test module while dropping its eviction-and-retry test #9, then restored NO_OOM coverage that had accidentally disappeared during that revision #10.
- Robert measured combined line coverage rising to 97.1% but questioned whether the additional maintenance cost justified tests that missed difficult concurrency cases, and requested removal of remaining bare blocks #11; Sami supplied that cleanup and defended dedicated coverage for the new flag #12.
- Andres Freund supported focused tests but recommended combining the related shared-memory test modules to reduce boilerplate and cluster startup costs #13; Michael Paquier also supported direct testing and proposed thinner SQL wrappers so scripts could construct specific edge cases #14.
- Sami ultimately planned to move dshash testing into test_dsm_registry and target PostgreSQL 20, identifying a missing size-limit API for GetNamedDSHash and reporting a separate proposal to address it #15; Michael agreed that the API extension could be useful and was too late for PostgreSQL 19 #16, leaving the OOM API committed and the test work deferred.