Mar 2026

1 commit
Remove bits* typedefs.
30 Mar 2026Nathan Bossartmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% surelanded as postedfrom patchset #127 of 7 reviewers saw the final version

The commit matches #12 modulo rebasing: its parent already contains every added uint32 line from the four omitted files, src/backend/access/heap/{heapam.c,heapam_handler.c} and src/include/access/{heapam.h,tableam.h}. All remaining added and removed lines match, and Nathan confirms the landing in #18.

  • Álvaro Herrerasaw the final versiontrailerÁlvaro defended the typedefs as useful markers for independent bitmasks but declined to block removal, and only mechanical rebase changes followed #2 #5.
  • Tom Lanesaw the final versiontrailerTom examined inconsistent usage, proposed documenting the retained types, then supported removal and accepted the extension compatibility impact #3 #7 #13 #17.
  • Robert Haassaw the final versiontrailerRobert assessed the patch's scope and argued that removal was the sensible standardization direction because wider adoption would cause excessive churn, with only mechanical rebase changes afterward #4.
  • Michael Paquiersaw the final versiontrailerMichael raised extension compilation breakage and questioned the urgency of removal while remaining neutral, with only mechanical rebase changes afterward #8.
  • Peter Eisentrautsaw the final versiontrailerPeter expressed mild support for removal while observing the lack of consensus, and only mechanical rebase changes followed #9.
  • Melanie Plagemansaw the final versiontrailerMelanie supported removal and identified newly expanded public usage, prompting the mechanical rebase that extended the same substitutions to those interfaces #11 #12.
  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerIlmari reviewed the compatibility consequences and proposed conditionally retaining the typedefs for extensions, which Nathan declined #15 #16.

Credits across 1 commit

Author
Nathan BossartLLM1
Reviewer
Alvaro Herrera1
Dagfinn Ilmari Mannsåker1
Melanie Plageman1
Michael Paquier1
Peter Eisentraut1
Robert Haas1
Tom Lane1
Committer
Nathan Bossart1

N LLM means N of the credits come from LLM analysis, not from commit trailers.