pg_options.sample
pg_options.sample coming with 7.0.x does not work because:
1) it exceeds 4096 bytes while read_pg_options() reads only first 4096
bytes of it.
2) it allows spaces around "=" while parese_options() does not.
Apparently the sample file was brought in without enough testings when
7.0 was developed. What should we do now?
Should we fix pg_options code so that PostgreSQL accepts the sample
file? Or just leave it and add a new entry to the FAQ?
--
Tatsuo Ishii
Tatsuo Ishii <t-ishii@sra.co.jp> writes:
pg_options.sample coming with 7.0.x does not work because:
1) it exceeds 4096 bytes while read_pg_options() reads only first 4096
bytes of it.
Oliver Elphick posted a patch for this recently (pghackers 28-Nov)
and noted that it seemed already fixed in 7.1 sources.
What should we do now?
Nothing, I think. If you want to apply Oliver's patch to the
REL7_0_PATCHES branch, go ahead --- but I don't think there'll be
a 7.0.4 release, so it's probably wasted effort.
If the bug still exists in 7.1 sources, then of course we need to
fix it there...
regards, tom lane
Tatsuo Ishii <t-ishii@sra.co.jp> writes:
pg_options.sample coming with 7.0.x does not work because:
1) it exceeds 4096 bytes while read_pg_options() reads only first 4096
bytes of it.Oliver Elphick posted a patch for this recently (pghackers 28-Nov)
and noted that it seemed already fixed in 7.1 sources.
Thanks for poting it out.
What should we do now?
Nothing, I think. If you want to apply Oliver's patch to the
REL7_0_PATCHES branch, go ahead --- but I don't think there'll be
a 7.0.4 release, so it's probably wasted effort.If the bug still exists in 7.1 sources, then of course we need to
fix it there...regards, tom lane
Agreed.
--
Tatsuo Ishii