6.2 protocol

Started by Bruce Momjianabout 25 years ago7 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

ODBC still has code to handle 6.2 backends:

/* This startup packet is to support pre-Postgres 6.3 protocol */
typedef struct _StartupPacket6_2
{
unsigned int authtype;
char database[PATH_SIZE];
char user[NAMEDATALEN];
char options[ARGV_SIZE];
char execfile[ARGV_SIZE];
char tty[PATH_SIZE];
} StartupPacket6_2;

Do we still want to carry that code around in ODBC?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: 6.2 protocol

Bruce Momjian <pgman@candle.pha.pa.us> writes:

ODBC still has code to handle 6.2 backends:
Do we still want to carry that code around in ODBC?

I'd suggest retiring the 6.2 *and* 6.3 code from ODBC, so that it only
needs to support one protocol version, and then we can also retire its
"6.2/6.3/6.4" protocol option switch. AFAICS that option switch serves
only to confuse newbies --- I recall a fair number of questions along
the line of "I'm running PG 6.5 (or 7.0), where do I get an ODBC that
will talk to it?" since after all it does not say ">= 6.4".

Besides, anyone still running 6.3 or before needs to be prodded,
none too gently, to upgrade ...

regards, tom lane

#3Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: [HACKERS] 6.2 protocol

OK, I have applied the following patch to remove ODBC protocol-version
handling. I have kept the protocol-version fields and assignments, in
case it is useful in the future. Comments?

Bruce Momjian <pgman@candle.pha.pa.us> writes:

ODBC still has code to handle 6.2 backends:
Do we still want to carry that code around in ODBC?

I'd suggest retiring the 6.2 *and* 6.3 code from ODBC, so that it only
needs to support one protocol version, and then we can also retire its
"6.2/6.3/6.4" protocol option switch. AFAICS that option switch serves
only to confuse newbies --- I recall a fair number of questions along
the line of "I'm running PG 6.5 (or 7.0), where do I get an ODBC that
will talk to it?" since after all it does not say ">= 6.4".

Besides, anyone still running 6.3 or before needs to be prodded,
none too gently, to upgrade ...

regards, tom lane

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Attachments:

/bjm/difftext/plainDownload+71-94
#4Hiroshi Inoue
Inoue@tpf.co.jp
In reply to: Bruce Momjian (#3)
RE: [PATCHES] Re: [HACKERS] 6.2 protocol

-----Original Message-----
From: Bruce Momjian

OK, I have applied the following patch to remove ODBC protocol-version
handling. I have kept the protocol-version fields and assignments, in
case it is useful in the future. Comments?

Hmm, could only you 2 decide it so quickly ?
For whom pgsql ODBC driver is ?

Regards,
Hiroshi Inoue

#5Bruce Momjian
bruce@momjian.us
In reply to: Hiroshi Inoue (#4)
Re: RE: [PATCHES] Re: [HACKERS] 6.2 protocol

-----Original Message-----
From: Bruce Momjian

OK, I have applied the following patch to remove ODBC protocol-version
handling. I have kept the protocol-version fields and assignments, in
case it is useful in the future. Comments?

Hmm, could only you 2 decide it so quickly ?
For whom pgsql ODBC driver is ?

I can put it back. You want it back?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#6Hiroshi Inoue
Inoue@tpf.co.jp
In reply to: Bruce Momjian (#5)
RE: RE: [PATCHES] Re: [HACKERS] 6.2 protocol

-----Original Message-----
From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]

-----Original Message-----
From: Bruce Momjian

OK, I have applied the following patch to remove ODBC protocol-version
handling. I have kept the protocol-version fields and assignments, in
case it is useful in the future. Comments?

Hmm, could only you 2 decide it so quickly ?
For whom pgsql ODBC driver is ?

I can put it back. You want it back?

Yes.
ISTM discussion is needed before the change.

Regards,
Hiroshi Inoue

#7Bruce Momjian
bruce@momjian.us
In reply to: Hiroshi Inoue (#6)
Re: RE: [PATCHES] Re: [HACKERS] 6.2 protocol

Hmm, could only you 2 decide it so quickly ?
For whom pgsql ODBC driver is ?

I can put it back. You want it back?

Yes.
ISTM discussion is needed before the change.

OK, let's discuss. Why should ODBC still support 6.3 and 6.2 databases?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026